Skip to content

[do-not-merge]added config for document server setup #10826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

S-Panta
Copy link
Contributor

@S-Panta S-Panta commented Jan 2, 2025

Description

A single file docker-compose inside directory tests/acceptance/docker/documentServer can be used to start the necessary service for app provider test along with the latest ocis local build.
Make sure to add all the hosts in /etc/hosts folder before running the docker compose file

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Copy link

update-docs bot commented Jan 2, 2025

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@S-Panta S-Panta self-assigned this Jan 2, 2025
@S-Panta S-Panta added the QA:team label Jan 2, 2025
@mmattel
Copy link
Contributor

mmattel commented Jan 2, 2025

@S-Panta Q: did you derive from ocis-full? If yes we should add a note+link. This eases finding changes in the source that can be trasnported to this compose definition. Just my 2c

@S-Panta
Copy link
Contributor Author

S-Panta commented Jan 3, 2025

@S-Panta Q: did you derive from ocis-full? If yes we should add a note+link. This eases finding changes in the source that can be trasnported to this compose definition. Just my 2c

The environment variable were matched both from ocis_full and config inside docker-compose` of web

@S-Panta S-Panta force-pushed the setup-app-provider-for-test branch from 9edf71a to feb03bd Compare January 7, 2025 09:23
@S-Panta S-Panta marked this pull request as ready for review January 7, 2025 10:28
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also make a separate env file for tags such as TIKA_IMAGE, LOG_DRIVER , ..... or other possible things to flexibility?

Copy link
Contributor

@amrita-shrestha amrita-shrestha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why added different folder documentServer?
we have make file inside tests/acceptance/docker which help us to run different service

@S-Panta S-Panta force-pushed the setup-app-provider-for-test branch from feb03bd to 8843b2a Compare February 4, 2025 05:00
@S-Panta S-Panta force-pushed the setup-app-provider-for-test branch from 8843b2a to 9ea5f3c Compare February 4, 2025 05:02
Copy link

sonarqubecloud bot commented Feb 4, 2025

Comment on lines +595 to +601
127.0.0.1 ocis.owncloud.test
127.0.0.1 traefik.owncloud.test
127.0.0.1 minio.owncloud.test
127.0.0.1 keycloak.owncloud.test
127.0.0.1 collabora.owncloud.test
127.0.0.1 onlyoffice.owncloud.test
127.0.0.1 wopiserver-oo.owncloud.test
Copy link
Contributor

@amrita-shrestha amrita-shrestha Feb 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

format error

@S-Panta S-Panta changed the title added config for document server setup [do-not-merge]added config for document server setup Feb 5, 2025
@S-Panta S-Panta marked this pull request as draft February 5, 2025 05:01
@S-Panta
Copy link
Contributor Author

S-Panta commented Feb 14, 2025

There are already yml file inside tests/acceptance/docker/src and it would be unwise to create a new folder document server and put all configuration in it. In this PR, I just moved the configuration from ocis_dull. But moving all these config inside tests/acceptance/docker/src will require some research.

@saw-jan
Copy link
Member

saw-jan commented Feb 18, 2025

Let's continue this one next sprint. we have other priorities for the current sprint

@S-Panta S-Panta removed their assignment Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set Up Required Services for Testing in a Centralized Location
6 participants