Skip to content

Conversation

@PVince81
Copy link
Contributor

@PVince81 PVince81 commented Nov 3, 2016

Backport of #26534 to stable9.1

@PVince81 PVince81 added this to the 9.1.3 milestone Nov 3, 2016
@mention-bot
Copy link

@PVince81, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rullzer and @stweil to be potential reviewers.

@davitol
Copy link
Contributor

davitol commented Nov 4, 2016

👎 Check sharing and setting as favorite with several files and the issue keeps happening

@PVince81
Copy link
Contributor Author

@davitol works for me, my steps:

  1. Create two users "user1" and "user2"
  2. Login as "user1"
  3. Create a folder "test"
  4. Share "test" with "user2"
  5. Refresh the page to force the indicator to appear (this is another bug: Share indicator not appearing upon sharing, only after refresh #25311)
  6. See that the share indicator is on the row of "test"
  7. Favorite/unfavorite the file

On stable9.1: indicator disappears
On this PR: indicator stays

@davitol
Copy link
Contributor

davitol commented Nov 11, 2016

👍 WFM with @PVince81 steps ( i guess I skipped the 5th step) . Sorry for the noise

@DeepDiver1975 DeepDiver1975 merged commit 709d324 into stable9.1 Nov 11, 2016
@DeepDiver1975 DeepDiver1975 deleted the stable9.1-fix_disappearing_share_info-patch branch November 11, 2016 09:16
@lock
Copy link

lock bot commented Aug 4, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants