Skip to content

Conversation

@mjobst-necls
Copy link
Contributor

Description

The share information got lost after rerendering the list entry. That was the case, because the data-share-types were not added back to the fileInfo on row creation.

Related Issue

#26241

Motivation and Context

It's a little bugfix, so I don't wanna write a big comment. The share information stays visible in the file list.

How Has This Been Tested?

Chrome (current) on Ubuntu 16.04

Screenshots (if appropriate):

screencast-2016-11-02-19 09 02

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

I'm not sure how to implement this in a unit test. Any ideas?

@mention-bot
Copy link

@mjobst-necls, thanks for your PR! By analyzing the history of the files in this pull request, we identified @PVince81, @rullzer and @stweil to be potential reviewers.

@PVince81
Copy link
Contributor

PVince81 commented Nov 3, 2016

👍 looks good, thanks!

@PVince81
Copy link
Contributor

PVince81 commented Nov 3, 2016

@lock
Copy link

lock bot commented Aug 4, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants