code format and minor lint issues #2777
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abelgardep
suggested changes
Jan 10, 2020
Comment on lines
732
to
736
| if (powerManager != null) { | ||
| return powerManager.isPowerSaveMode(); | ||
| } else { | ||
| return false; | ||
| } |
Contributor
There was a problem hiding this comment.
It is simpler this way, don't you think?
return (powerManager != null) && powerManager.isPowerSaveMode();
Contributor
Author
There was a problem hiding this comment.
It is and I changed it.
Btw, I would rater convert every touched file to Kotlin. But with this #2680 experience, it's a task of someone else
Contributor
There was a problem hiding this comment.
Thanks for the change. About converting files to kotlin, i consider that it could be great but only if an optimization is performed. I see no point in migrating to kotlin and keep java style.
abelgardep
approved these changes
Jan 13, 2020
Collaborator
|
Code cleaning. Some checks:
approved |
(cherry picked from commit 44769d0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are just code format lines and some minor lint issues. I opened this as an additional pull request to keep #2776 small.
Normally it should bot be a big deal to accept them.