Kotlinize

[hannesa2]

During #2679 I kotlinize some files and fixed some lint warnings.
To keep #2679 I separated my work into two PR.

[davigonz]

Wow, this is great, thanks so much! We will review it

[abelgardep]

@hannesa2 Some changes requested

[hannesa2]

I applied most of the suggestions

[abelgardep]

Thanks for the changes! But there are some pending ones that require some attention and research. As you know, we may get some nullability problems if we have kotlin code running with java code with not nullable parameters. Some files in this pr have a lot of usages and we should research a little bit which params are nullable and which not. That's why is not trivial to kotlinize files.

For example, i have found an usage of uploadNewFile from UriUploader.java that sends a null to a parameter set as not nullable.

[hannesa2]

Sorry, I missed them because of this

But wouldn't it better and more efficient when you change immediate in code and commit your code-format wishes ? Tastes are different and efficiency matters !

Most of them are autogenerated by Android Studio

[abelgardep]

Autogenerate kotlin code from java using AS is not always the best solution. If i kotlinize a file, i should research and check if everything is working as it was before since we have not a full test coverage (we are on our way with new arch). I found that problem but perhaps there are even more.

[jesmrec]

@hannesa2 do you mind if we kotlinize these classes in the re-architecting process, or do you prefer to apply the suggestions of @abelgardep to move forward this PR?

[hannesa2]

I've no strong opinion here, I don't depend on it. Tell me what to do. Even an unmerged "close" is an option

[jesmrec]

Ok. Let's close ftm. In case we want to take advantage of this, will reopen.

Thanks for your enagagement.