Revert "Restrict autoscaling privileges to AWSBatch* resources" #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ca3d5d3.
Member
|
Oh indeed, maybe we should've been looking at this doc, not the doc I linked to in the original issue |
olivermeyer
deleted the
revert-12-restrict-batch_execution_role-privileges
branch
Limess
pushed a commit
to signal-ai/terraform-aws-metaflow
that referenced
this pull request
May 26, 2022
…bounds#12)" (outerbounds#19) This reverts commit ca3d5d3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #12
@oavdeev does this work for you? I'm afraid I might have broken some other permissions. I'm now getting the following error:
It seems that the
resource_prefix(in this casecustom-metaflow) is being prepended to the autoscaling group name. I couldn't find where this is defined. I re-built with0.3.2and this error went away (but I got another one 😬)