Restrict autoscaling privileges to AWSBatch* resources #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oavdeev
approved these changes
Apr 21, 2022
Member
oavdeev
left a comment
oavdeev
left a comment
There was a problem hiding this comment.
LGTM! At some point we should adopt other parts of the policy too though
oavdeev
pushed a commit
that referenced
this pull request
Apr 22, 2022
Limess
pushed a commit
to signal-ai/terraform-aws-metaflow
that referenced
this pull request
May 26, 2022
Limess
pushed a commit
to signal-ai/terraform-aws-metaflow
that referenced
this pull request
May 26, 2022
…bounds#12)" (outerbounds#19) This reverts commit ca3d5d3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I restrict the
autoscalingprivileges toAWSBatch*resources for thebatch_execution_role.This addresses #11.