static analysis: collect basic information about archive file #993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Max Fisher <maxfisher@google.com>
…p by test Signed-off-by: Max Fisher <maxfisher@google.com>
Signed-off-by: Max Fisher <maxfisher@google.com>
calebbrown
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow up to #978 and part of #959.
Static analysis now collects extra metadata about the archive file (file size and detected type, as well as SHA256 introduced in #978), and stores them in a new
ArchiveResultstruct which is part of the static analysis results.To implement this, an
Optionpattern is introduced to thebasicdata.Analyzefunction so that it can be reused for archive analysis, while also skipping over the line length analysis which is not relevant for binary files.For now, this new data is not written to the results JSON file and so not externally observable. This final step will be introduced in a future PR alongside a schema update.