Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add archive checksum #978

Merged
merged 3 commits into from
Dec 11, 2023
Merged

Add archive checksum #978

merged 3 commits into from
Dec 11, 2023

Conversation

h0x0er
Copy link
Contributor

@h0x0er h0x0er commented Nov 29, 2023

Refer #959

@h0x0er
added sha256 checksum of archive in staticanalysis result
8b72055 
Signed-off-by: h0x0er <jatink843@protonmail.com>
maxfisher-g
maxfisher-g requested changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@maxfisher-g maxfisher-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Just have one small change to request

sandboxes/staticanalysis/staticanalyze.go Outdated Show resolved Hide resolved
@h0x0er
logging error instead of returning
463a021 
Signed-off-by: h0x0er <jatink843@protonmail.com>
@h0x0er
Copy link
Contributor Author

h0x0er commented Dec 6, 2023

@maxfisher-g , I had pushed the requested change. Thanks for reviewing. 😃

maxfisher-g
maxfisher-g approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@maxfisher-g maxfisher-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved once the nit is addressed

sandboxes/staticanalysis/staticanalyze.go Outdated Show resolved Hide resolved
@h0x0er
nit: removed unnecessary format
424b6be 
Signed-off-by: h0x0er <jatink843@protonmail.com>
@maxfisher-g maxfisher-g merged commit 40fa3a1 into ossf:main Dec 11, 2023
10 checks passed
@maxfisher-g
Copy link
Contributor

Merged, thank you @h0x0er!

@maxfisher-g maxfisher-g mentioned this pull request Jan 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxfisher-g maxfisher-g maxfisher-g approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@h0x0er @maxfisher-g