Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster sync (w/o iavl v1) #7632

Closed
wants to merge 5 commits into from
Closed

Faster sync (w/o iavl v1) #7632

wants to merge 5 commits into from

Conversation

faddat
Copy link
Member

@faddat faddat commented Feb 28, 2024

  • initial changes
  • tidy
  • faster than 3bps but not tons
  • best performing changeset

Closes: #XXX

What is the purpose of the change

Add a description of the overall background and high level changes that this PR introduces

(E.g.: This pull request improves documentation of area A by adding ....

Testing and Verifying

(Please pick one of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added unit test that validates ...
  • Added integration tests for end-to-end deployment with ...
  • Extended integration test for ...
  • Manually verified the change by ...

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes?
  • Changelog entry added to Unreleased section of CHANGELOG.md?

Where is the change documented?

  • Specification (x/{module}/README.md)
  • Osmosis documentation site
  • Code comments?
  • N/A

Copy link
Contributor

mergify bot commented Feb 28, 2024

⚠️ The sha of the head commit of this PR conflicts with #7611. Mergify cannot evaluate rules on this PR. ⚠️

@czarcas7ic
Copy link
Member

Hey, I am testing comet's changes

cometbft/cometbft#2475
cometbft/cometbft#2515

Been having really good results

@czarcas7ic
Copy link
Member

Closing due to improvement completed upstream, and backporting to our fork. See osmosis-labs/cometbft#16

@czarcas7ic czarcas7ic closed this Mar 7, 2024
Copy link
Contributor

mergify bot commented Mar 7, 2024

⚠️ The sha of the head commit of this PR conflicts with #7611. Mergify cannot evaluate rules on this PR. ⚠️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants