test: sync much more quickly by changing settings in cometbft #7611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
@czarcas7ic when you check through this, make sure to check the replace statement for comet, as that's where the action is. In my test it was a good deal faster than default. In some ways it mirrors the strategy pursued by @mekeles And you'll recognize that pretty clearly when you look at the changes made to comet. |
mattverse
reviewed
Feb 29, 2024
| @@ -1,6 +1,6 @@ | |||
| module github.com/osmosis-labs/osmosis/v23 | |||
|
|
|||
| go 1.21 | |||
| go 1.22 | |||
|
Closing due to improvement completed upstream, and backporting to our fork. See osmosis-labs/cometbft#16 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Test changes to cometbft discussed in #shared-tendermint with @czarcas7ic against the osmosis application.
Currently it consists of the replace statement change and a refresh of the state sync script, as well as bringing comet current with changes from v0.37.x.
Testing and Verifying
(Please pick one of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation and Release Note
Unreleasedsection ofCHANGELOG.md?Where is the change documented?
x/{module}/README.md)