Add Pagination to Pool With Filter Query #3563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
C:x/gamm
mattverse
commented
Nov 29, 2022
| @@ -184,14 +175,14 @@ func (q Querier) PoolsWithFilter(ctx context.Context, req *types.QueryPoolsWithF | |||
| checks_needed++ | |||
| } | |||
|
|
|||
| for _, p := range pools { | |||
| var response = []*codectypes.Any{} | |||
| pageRes, err := query.FilteredPaginate(poolStore, req.Pagination, func(_, value []byte, accumulate bool) (bool, error) { | |||
There was a problem hiding this comment.
Using FilteredPaginate instead of Paginate method allows us to iterate until pagination count has been reached
There was a problem hiding this comment.
We can backport the fix for that to clean this up a little if we want.
(Or just copy/paste cosmos/cosmos-sdk#12253 into osmoutils)
There was a problem hiding this comment.
I was also checking generic pagination as well! Sad that we don't have it yet. I say we refactor this to use generic pagination later on when it gets backported and for now leave as is
czarcas7ic
reviewed
Nov 29, 2022
| var pool types.PoolI | ||
|
|
||
| err := q.cdc.UnpackAny(p, &pool) | ||
| pool, err := q.Keeper.UnmarshalPool(value) |
There was a problem hiding this comment.
where does this value as the input to UnmarshalPool come from?
There was a problem hiding this comment.
It comes from the FilteredPagination method, where it iterates over the given kv store!
mattverse
added
V:state/compatible/backport
mattverse
commented
Nov 29, 2022
x/gamm/keeper/grpc_query.go
Outdated
| return false, err | ||
| } | ||
|
|
||
| if accumulate { |
There was a problem hiding this comment.
required for offset in pagination
ValarDragon
approved these changes
Nov 30, 2022
mergify bot
pushed a commit
that referenced
this pull request
Nov 30, 2022
* Add Pagination to filter pool query * Use Filtered Pagination * Add logic for offset in pagination * Return false on response * Bug fix * Refactors for clean code * Remove snake cases * Fix typos * Clean more code (cherry picked from commit 1dedc28) # Conflicts: # proto/osmosis/gamm/v1beta1/query.proto # x/gamm/keeper/grpc_query.go # x/gamm/types/query.pb.go
This was referenced Nov 30, 2022
mergify bot
pushed a commit
that referenced
this pull request
Nov 30, 2022
* Add Pagination to filter pool query * Use Filtered Pagination * Add logic for offset in pagination * Return false on response * Bug fix * Refactors for clean code * Remove snake cases * Fix typos * Clean more code (cherry picked from commit 1dedc28)
ValarDragon
pushed a commit
that referenced
this pull request
Nov 30, 2022
* Add Pagination to filter pool query * Use Filtered Pagination * Add logic for offset in pagination * Return false on response * Bug fix * Refactors for clean code * Remove snake cases * Fix typos * Clean more code (cherry picked from commit 1dedc28) Co-authored-by: Matt, Park <45252226+mattverse@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
What is the purpose of the change
This PR adds pagination to pools with filter query.
As of right now, pagination is not included in the query for pools with filter, whist pagination is necessary as front end query heavily depends on pagination.
Brief Changelog
PoolsWithFilterquery in gammDocumentation and Release Note
Unreleasedsection inCHANGELOG.md? (yes / no)x/<module>/spec/) / Osmosis docs repo / not documented)