feat: add query.GenericFilteredPaginated #12253

facundomedica · 2022-06-14T17:40:09Z

Description

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

confirmed the correct type prefix in the PR title
confirmed ! in the type prefix if API or client breaking change
confirmed all author checklist items have been addressed
reviewed state machine logic
reviewed API design and naming
reviewed documentation is accurate
reviewed tests and test coverage
manually tested (if applicable)

…/filteredPaginated-generics

…cosmos/cosmos-sdk into facu/filteredPaginated-generics

…/filteredPaginated-generics

types/query/filtered_pagination.go

alexanderbez · 2022-06-15T15:33:15Z

types/query/filtered_pagination.go

+			}
+
+			protoMsg := any(new(V))
+			err := cdc.Unmarshal(iterator.Value(), protoMsg.(codec.ProtoMarshaler))


so V is an any, which is just an interface{}. Do we not need to type check here that V is a codec.ProtoMarshaler? Why not also make V of type codec.ProtoMarshaler?

I was trying to find a way of instantiating V (now T; not sure what to name these), which for some reason was impossible for me (always ended up getting **authz.Grant instead of *authz.Grant without the possibility to dereference it). With reflectit was quite easy, but I'm not sure if we would like to use it here. See my last commit: 6db3de3

This was what I was trying to do before:

protoMsg := any(new(T)).(codec.ProtoMarshaler) protoMsg := any(*new(T)).(codec.ProtoMarshaler)

None of these work... In short, we need to be able to initialize a variable with type T that is not nil. Is this possible with generics?

In Osmosis, I made V of type proto.Message for something similar here; https://github.com/osmosis-labs/osmosis/blob/main/tests/e2e/chain/config.go#L149-L162

codec.BinaryCodec calls for codec.ProtoMarshaler. It shouldn't be an issue, it seems like all of our generated protobuf structs are codec.ProtoMarshaler.
The issue we were discussing here has been solved by adding a constructor function.

types/query/filtered_pagination.go

…cosmos/cosmos-sdk into facu/filteredPaginated-generics

…/filteredPaginated-generics

types/query/filtered_pagination.go

robert-zaremba · 2022-06-16T21:42:07Z

Great, can we get it into 0.46?

types/query/filtered_pagination.go

alexanderbez

LGTM @facundomedica. Let's add a changelog entry prior to merge please.

…/filteredPaginated-generics

Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>

…cosmos/cosmos-sdk into facu/filteredPaginated-generics

facundomedica · 2022-06-27T11:02:02Z

I've implemented this as GenericFilteredPaginate and used it only in 3 places in authz. Should I go ahead and remove FilteredPaginate? So GenericFilteredPaginate turns into FilteredPaginate. Or do we want to keep it for now?

In the case we keep it as is I'll change the title to feat: add query.GenericFilteredPaginated to be accurate on what's being done here

alexanderbez

🎉

CHANGELOG.md

ValarDragon · 2022-06-27T19:41:15Z

btw can this be backported to 45?

alexanderbez · 2022-06-28T00:38:36Z

btw can this be backported to 45?

Yup! But we need to update v0.45.x to Go 1.18

I'm going to open a backport anyway in the meantime

(cherry picked from commit e5daf6b)

(cherry picked from commit e5daf6b) # Conflicts: # CHANGELOG.md # x/authz/keeper/grpc_query.go

* Update tag.yml * fix: update index of crisis invariant check logs (backport cosmos#12208) (cosmos#12210) * fix: update index of crisis invariant check logs (cosmos#12208) ## Description the info log messages describing invariant checks use the index to state progress (eg. `asserting crisis invariants inv=0/15`). this simple change makes them 1-indexed (eg. `asserting crisis invariants inv=1/15`). example before: <img width="374" alt="Screen Shot 2022-06-09 at 12 06 58 PM" src="https://user-images.githubusercontent.com/14897503/172925006-8810706c-0948-4e36-85b8-22813ccc9311.png"> Closes: #XXXX --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [x] added `!` to the type prefix if API or client breaking change - N/A - [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting)) - [x] provided a link to the relevant issue or specification - N/A - [x] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules) - N/A - [x] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing) - N/A - [x] added a changelog entry to `CHANGELOG.md` - [x] included comments for [documenting Go code](https://blog.golang.org/godoc) - N/A - [x] updated the relevant documentation or specification - N/A - [x] reviewed "Files changed" and left comments if necessary - N/A - [x] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) (cherry picked from commit 907df32) # Conflicts: # CHANGELOG.md * fix conflict Co-authored-by: Robert Pirtle <Astropirtle@gmail.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * fix: Refactor GetLastCompletedUpgrade [v0.45.x] (cosmos#12264) * fix: defaultGenTxGas to 10 times (cosmos#12314) * fix: edit validator bug from cli (cosmos#12317) * chore: update release notes (cosmos#12377) * feat: add query.GenericFilteredPaginated (backport cosmos#12253) (cosmos#12371) * chore: correctly install `tparse` in workflow Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Robert Pirtle <Astropirtle@gmail.com> Co-authored-by: Julien Robert <julien@rbrt.fr> Co-authored-by: HaeSung <hea9549.github@gmail.com> Co-authored-by: likhita-809 <78951027+likhita-809@users.noreply.github.com>

…mos#12371)

* Update tag.yml * fix: update index of crisis invariant check logs (backport cosmos#12208) (cosmos#12210) * fix: update index of crisis invariant check logs (cosmos#12208) ## Description the info log messages describing invariant checks use the index to state progress (eg. `asserting crisis invariants inv=0/15`). this simple change makes them 1-indexed (eg. `asserting crisis invariants inv=1/15`). example before: <img width="374" alt="Screen Shot 2022-06-09 at 12 06 58 PM" src="https://user-images.githubusercontent.com/14897503/172925006-8810706c-0948-4e36-85b8-22813ccc9311.png"> Closes: #XXXX --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [x] added `!` to the type prefix if API or client breaking change - N/A - [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting)) - [x] provided a link to the relevant issue or specification - N/A - [x] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules) - N/A - [x] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing) - N/A - [x] added a changelog entry to `CHANGELOG.md` - [x] included comments for [documenting Go code](https://blog.golang.org/godoc) - N/A - [x] updated the relevant documentation or specification - N/A - [x] reviewed "Files changed" and left comments if necessary - N/A - [x] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) (cherry picked from commit 907df32) # Conflicts: # CHANGELOG.md * fix conflict Co-authored-by: Robert Pirtle <Astropirtle@gmail.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * fix: Refactor GetLastCompletedUpgrade [v0.45.x] (cosmos#12264) * fix: defaultGenTxGas to 10 times (cosmos#12314) * fix: edit validator bug from cli (cosmos#12317) * chore: update release notes (cosmos#12377) * feat: add query.GenericFilteredPaginated (backport cosmos#12253) (cosmos#12371) * fix: update x/mint parameter validation (backport cosmos#12384) (cosmos#12396) * chore: optimize get last completed upgrade (cosmos#12268) * feat: improve GetLastCompletedUpgrade * rename * use var block * fix: Simulation is not deterministic due to GenTx (backport cosmos#12374) (cosmos#12437) * fix: use go install instead of go get in makefile (cosmos#12435) * chore: fumpt sdk v45 series cosmos#12442 * feat: Move AppModule.BeginBlock and AppModule.EndBlock to extension interfaces (backport cosmos#12603) (cosmos#12638) * feat: Move AppModule.BeginBlock and AppModule.EndBlock to extension interfaces (cosmos#12603) ## Description Most modules right now have a no-op for AppModule.BeginBlock and AppModule.EndBlock. We should move these methods off the AppModule interface so we have less deadcode, and instead move them to extension interfaces. 1. I added `BeginBlockAppModule` and `EndBlockAppModule` interface. 2. Remove the dead-code from modules that do no implement them 3. Add type casting in the the module code to use the new interface Closes: cosmos#12462 --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) (cherry picked from commit b65f3fe) # Conflicts: # CHANGELOG.md # x/authz/module/module.go # x/group/module/module.go # x/nft/module/module.go # x/params/module.go # x/slashing/module.go # x/upgrade/module.go * remove conflicts * remove conflicts * remove unused modules Co-authored-by: Sishir Giri <sishirg27@gmail.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> * feat: add message index event attribute to authz message execution (backport cosmos#12668) (cosmos#12673) * chore(store): upgrade iavl to v0.19.0 (backport cosmos#12626) (cosmos#12697) * feat: Add `GetParamSetIfExists` to prevent panic on breaking param changes (cosmos#12724) * feat: Add convenience method for constructing key to access account's balance for a given denom (backport cosmos#12674) (cosmos#12745) * feat: Add convenience method for constructing key to access account's balance for a given denom (cosmos#12674) This PR adds a convenience method for constructing the key necessary to query for the account's balance of a given denom. I ran into this issue since we are using ABCI query now to perform balance requests because we are also requesting merkle proofs for the returned balance [here](https://github.com/celestiaorg/celestia-node/pull/911/files#diff-0ee31f5a7bd88e9f758e6bebdf3ee36365519e55a451098d9638c39afe5eac42R144). It would be nice to have a definitive convenience method for constructing the key. [Ref.](github.com/celestiaorg/celestia-node/pull/911) (cherry picked from commit a1777a8) # Conflicts: # CHANGELOG.md # x/bank/legacy/v043/store.go # x/bank/types/keys.go * Update CHANGELOG.md * fix conflict Co-authored-by: rene <41963722+renaynay@users.noreply.github.com> Co-authored-by: Marko <marbar3778@yahoo.com> * chore: bump tm in 0.45.x (cosmos#12784) * bump tendermint version * add changelog entry * replace on jhump * updates * updates * updates Co-authored-by: Aleksandr Bezobchuk <aleks.bezobchuk@gmail.com> * chore: 0.45.7 changelog prep (cosmos#12821) * prepare for release * modify release notes * chore: migrate from registry to delegation keeper Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Robert Pirtle <Astropirtle@gmail.com> Co-authored-by: Julien Robert <julien@rbrt.fr> Co-authored-by: HaeSung <hea9549.github@gmail.com> Co-authored-by: likhita-809 <78951027+likhita-809@users.noreply.github.com> Co-authored-by: Robert Zaremba <robert@zaremba.ch> Co-authored-by: Adu <foriteration@gmail.com> Co-authored-by: Jacob Gadikian <jacobgadikian@gmail.com> Co-authored-by: Sishir Giri <sishirg27@gmail.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> Co-authored-by: rene <41963722+renaynay@users.noreply.github.com> Co-authored-by: Aleksandr Bezobchuk <aleks.bezobchuk@gmail.com>

…mos#12371)

poc

fa3014e

facundomedica requested review from alexanderbez and ValarDragon June 14, 2022 17:40

github-actions bot added the C:x/authz label Jun 14, 2022

facundomedica and others added 7 commits June 14, 2022 14:42

Merge branch 'main' into facu/filteredPaginated-generics

619f716

Merge branch 'main' of https://github.com/cosmos/cosmos-sdk into facu…

a920332

…/filteredPaginated-generics

progress

cb28171

Merge branch 'facu/filteredPaginated-generics' of https://github.com/…

b5b5a64

…cosmos/cosmos-sdk into facu/filteredPaginated-generics

Merge branch 'main' of https://github.com/cosmos/cosmos-sdk into facu…

3dd87d2

…/filteredPaginated-generics

fix when returned object is nil

4ebaaaa

Merge branch 'main' into facu/filteredPaginated-generics

9eeb401

alexanderbez reviewed Jun 15, 2022

View reviewed changes

facundomedica added 2 commits June 15, 2022 14:19

use reflect to accept codec.ProtoMarshaler

6db3de3

suggestion

85fc29b

github-advanced-security bot found potential problems Jun 15, 2022

View reviewed changes

types/query/filtered_pagination.go Fixed Show fixed Hide fixed

facundomedica and others added 6 commits June 15, 2022 15:43

try out constructor

6353df0

rename

23b5fdc

Merge branch 'main' into facu/filteredPaginated-generics

fff311f

docs

bf01daa

Merge branch 'facu/filteredPaginated-generics' of https://github.com/…

1cf2af3

…cosmos/cosmos-sdk into facu/filteredPaginated-generics

Merge branch 'main' of https://github.com/cosmos/cosmos-sdk into facu…

314d622

…/filteredPaginated-generics

facundomedica marked this pull request as ready for review June 16, 2022 13:37

facundomedica requested a review from a team as a code owner June 16, 2022 13:37

docs

2c59802

alexanderbez reviewed Jun 16, 2022

View reviewed changes

types/query/filtered_pagination.go Show resolved Hide resolved

types/query/filtered_pagination.go Outdated Show resolved Hide resolved

types/query/filtered_pagination.go Show resolved Hide resolved

ValarDragon reviewed Jun 17, 2022

View reviewed changes

types/query/filtered_pagination.go Outdated Show resolved Hide resolved

alexanderbez approved these changes Jun 21, 2022

View reviewed changes

facundomedica and others added 2 commits June 27, 2022 07:51

Merge branch 'main' of https://github.com/cosmos/cosmos-sdk into facu…

a93666b

…/filteredPaginated-generics

Apply suggestions from code review

40cd7b6

Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>

facundomedica and others added 2 commits June 27, 2022 12:57

Merge branch 'main' into facu/filteredPaginated-generics

61311bd

Merge branch 'facu/filteredPaginated-generics' of https://github.com/…

51ca9b5

…cosmos/cosmos-sdk into facu/filteredPaginated-generics

cl++, small fix

baf7f7f

facundomedica changed the title ~~feat!: make query.FilteredPaginated use generics~~ feat: add query.GenericFilteredPaginated Jun 27, 2022

alexanderbez approved these changes Jun 27, 2022

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

facundomedica and others added 2 commits June 27, 2022 08:20

cl++

b0070c2

Merge branch 'main' into facu/filteredPaginated-generics

7e955a9

ValarDragon approved these changes Jun 27, 2022

View reviewed changes

alexanderbez added backport/0.45.x backport/0.46.x PR scheduled for inclusion in the v0.46's next stable release labels Jun 28, 2022

alexanderbez merged commit e5daf6b into main Jun 28, 2022

alexanderbez deleted the facu/filteredPaginated-generics branch June 28, 2022 00:38

mergify bot pushed a commit that referenced this pull request Jun 28, 2022

feat: add query.GenericFilteredPaginated (#12253)

6660362

(cherry picked from commit e5daf6b)

mergify bot mentioned this pull request Jun 28, 2022

feat: add query.GenericFilteredPaginated (backport #12253) #12370

Merged

mergify bot pushed a commit that referenced this pull request Jun 28, 2022

feat: add query.GenericFilteredPaginated (#12253)

fcc148c

(cherry picked from commit e5daf6b) # Conflicts: # CHANGELOG.md # x/authz/keeper/grpc_query.go

mergify bot mentioned this pull request Jun 28, 2022

feat: add query.GenericFilteredPaginated (backport #12253) #12371

Merged

alexanderbez pushed a commit that referenced this pull request Jun 28, 2022

feat: add query.GenericFilteredPaginated (#12253) (#12370)

f0bf4c3

alexanderbez pushed a commit that referenced this pull request Jun 28, 2022

feat: add query.GenericFilteredPaginated (backport #12253) (#12371)

f2d9444

randy75828 pushed a commit to Switcheo/cosmos-sdk that referenced this pull request Aug 10, 2022

feat: add query.GenericFilteredPaginated (backport cosmos#12253) (cos…

b3b1ec6

…mos#12371)

ValarDragon mentioned this pull request Nov 29, 2022

Add Pagination to Pool With Filter Query osmosis-labs/osmosis#3563

Merged

faddat mentioned this pull request Dec 11, 2023

chore: update to v0.45.16 cudoventures/cosmos-sdk#16

Draft

19 tasks

JeancarloBarrios pushed a commit to agoric-labs/cosmos-sdk that referenced this pull request Sep 28, 2024

feat: add query.GenericFilteredPaginated (backport cosmos#12253) (cos…

4c4f657

…mos#12371)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add query.GenericFilteredPaginated #12253

feat: add query.GenericFilteredPaginated #12253

facundomedica commented Jun 14, 2022 •

edited

Loading

alexanderbez Jun 15, 2022

facundomedica Jun 15, 2022

facundomedica Jun 15, 2022

ValarDragon Jun 15, 2022

facundomedica Jun 16, 2022

robert-zaremba commented Jun 16, 2022

alexanderbez left a comment

facundomedica commented Jun 27, 2022 •

edited

Loading

alexanderbez left a comment

ValarDragon commented Jun 27, 2022

alexanderbez commented Jun 28, 2022

feat: add query.GenericFilteredPaginated #12253

feat: add query.GenericFilteredPaginated #12253

Conversation

facundomedica commented Jun 14, 2022 • edited Loading

Description

Author Checklist

Reviewers Checklist

alexanderbez Jun 15, 2022

Choose a reason for hiding this comment

facundomedica Jun 15, 2022

Choose a reason for hiding this comment

facundomedica Jun 15, 2022

Choose a reason for hiding this comment

ValarDragon Jun 15, 2022

Choose a reason for hiding this comment

facundomedica Jun 16, 2022

Choose a reason for hiding this comment

robert-zaremba commented Jun 16, 2022

alexanderbez left a comment

Choose a reason for hiding this comment

facundomedica commented Jun 27, 2022 • edited Loading

alexanderbez left a comment

Choose a reason for hiding this comment

ValarDragon commented Jun 27, 2022

alexanderbez commented Jun 28, 2022

facundomedica commented Jun 14, 2022 •

edited

Loading

facundomedica commented Jun 27, 2022 •

edited

Loading