Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

virtual-staking: jailing / tombstoning tests #142

Merged
merged 15 commits into from
Oct 12, 2023

Conversation

uint
Copy link
Contributor

@uint uint commented Oct 11, 2023

I never finished the tests for jailing/slashing, but I have this small helper you might find useful for setting the slash ratio in tests @maurolacy

Use this branch however you want, if you want!

@uint uint requested a review from maurolacy October 11, 2023 07:17
@maurolacy
Copy link
Collaborator

Nice. Let's just merge this as part of the virtual-staking jailing / tombstoning tests.

@maurolacy maurolacy force-pushed the 132-more-virtual-staking-tests branch from 28a98bb to 017c227 Compare October 11, 2023 11:11
@maurolacy maurolacy changed the title virtual-staking: set slash ratio in tests virtual-staking: jailing / tombstoning tests Oct 11, 2023
@maurolacy maurolacy marked this pull request as ready for review October 11, 2023 13:10
@maurolacy
Copy link
Collaborator

First round of tests done, and implementation adjusted. A series of FIXMEs / TODOs will be dealt with in a follow-up.

Copy link
Collaborator

@maurolacy maurolacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. :-)

@maurolacy maurolacy merged commit 19b1433 into main Oct 12, 2023
2 checks passed
@maurolacy maurolacy deleted the 132-more-virtual-staking-tests branch October 12, 2023 08:16
@maurolacy
Copy link
Collaborator

Just for the record, this is a follow-up of #137, with tests and some important fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants