Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

F/slash jailed validators #137

Merged
merged 4 commits into from
Oct 10, 2023
Merged

F/slash jailed validators #137

merged 4 commits into from
Oct 10, 2023

Conversation

maurolacy
Copy link
Collaborator

@maurolacy maurolacy commented Oct 9, 2023 •
edited
Loading

This slashes jailed validators as well as tombstoned ones, for consistency with Consumer side accounting; both on-chain, and in-contract (virtual-staking) after #136.

@maurolacy maurolacy changed the base branch from main to f/slashing-accounting October 9, 2023 08:14
@maurolacy maurolacy requested review from uint and hashedone October 9, 2023 09:28
@maurolacy maurolacy force-pushed the f/slash-jailed-validators branch 3 times, most recently from b6d2c2f to eae2968 Compare October 9, 2023 10:20
@maurolacy maurolacy changed the base branch from f/slashing-accounting to main October 9, 2023 10:34
@maurolacy maurolacy force-pushed the f/slash-jailed-validators branch from eae2968 to 808c1d2 Compare October 9, 2023 10:39
JakeHartnell
JakeHartnell approved these changes Oct 9, 2023
View reviewed changes
Copy link
Collaborator

@JakeHartnell JakeHartnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can't wait to test all this.

@maurolacy maurolacy merged commit 9beccb6 into main Oct 10, 2023
2 checks passed
@maurolacy
Copy link
Collaborator Author

LGTM, can't wait to test all this.

Hi, will do a release once #136, #138 and related follow-ups are merged, which should be soon.

@maurolacy maurolacy deleted the f/slash-jailed-validators branch October 10, 2023 06:22
@uint uint mentioned this pull request Oct 12, 2023
Closed
@maurolacy maurolacy mentioned this pull request Oct 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeHartnell JakeHartnell JakeHartnell approved these changes

@uint uint Awaiting requested review from uint

@hashedone hashedone Awaiting requested review from hashedone

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maurolacy @JakeHartnell