-
Notifications
You must be signed in to change notification settings - Fork 123
Map AT abbreviations to Osmose equivalent #2510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
at:urban30 and at:urban40 have been superseded by at:city_limit30 and at:city_limit40 (which will be checked in a separate plugin).
Changed to commonly understood abbreviations
Due to side effects
b055ac3
to
5967ce3
Compare
@Famlam |
Are these well-known abbreviations, as I'm unable to find them on e.g. Wikipedia or so? |
No, I didn't. When I wrote TagFix_Maxspeed_AT.py, I figured that for further use in AT specific plugins, it would be handy to have codes that are meaningful (believing that the AT-1 and such were OSmose internal). According to ISO-3166-2:AT however, some bureaucrat decided that meaning is overrated. Don't stress over it, feel free to change the codes back to the original (of course I can do that as well, just let me know). |
@frodrigo your preference? |
Revert |
Ok, will make the revert commit tonight or Wednesday :) |
I made the revert PR as #2511 because that was easier. Closing this PR |
NSI uses the country codes as defined in https://en.wikipedia.org/wiki/ISO_3166-2:AT
As the country codes were redefined in #2504 we need to map them to the ISO equivalent
@wolfbert