Skip to content

Map AT abbreviations to Osmose equivalent #2510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Conversation

Famlam
Copy link
Collaborator

@Famlam Famlam commented May 18, 2025

NSI uses the country codes as defined in https://en.wikipedia.org/wiki/ISO_3166-2:AT
As the country codes were redefined in #2504 we need to map them to the ISO equivalent

@wolfbert

wolfbert added 4 commits May 17, 2025 18:01
at:urban30 and at:urban40 have been superseded by at:city_limit30 and at:city_limit40 (which will be checked in a separate plugin).
Changed to commonly understood abbreviations
Due to side effects
@Famlam Famlam force-pushed the famlam-nsi-austria branch from b055ac3 to 5967ce3 Compare May 18, 2025 08:29
@wolfbert
Copy link
Contributor

@Famlam
Sorry for the additional work, I wasn't aware that the "AT-1" etc. are official (numbers for Austrian provinces aren't used in everyday life, abbreviations are understood). So just in case this creates problems, we can revert this.

@Famlam
Copy link
Collaborator Author

Famlam commented May 18, 2025

I wasn't aware that the "AT-1" etc. are official (numbers for Austrian provinces aren't used in everyday life, abbreviations are understood). So just in case this creates problems, we can revert this.

Are these well-known abbreviations, as I'm unable to find them on e.g. Wikipedia or so?
(I think that they are only used internally in Osmose (the part after the - at least), or am I wrong and did you see AT-1/2/3/... somewhere in the UI?)

@wolfbert
Copy link
Contributor

id you see AT-1/2/3/... somewhere in the UI?)

No, I didn't. When I wrote TagFix_Maxspeed_AT.py, I figured that for further use in AT specific plugins, it would be handy to have codes that are meaningful (believing that the AT-1 and such were OSmose internal). According to ISO-3166-2:AT however, some bureaucrat decided that meaning is overrated. Don't stress over it, feel free to change the codes back to the original (of course I can do that as well, just let me know).

@Famlam
Copy link
Collaborator Author

Famlam commented May 18, 2025

@frodrigo your preference?

@frodrigo
Copy link
Contributor

@frodrigo your preference?

Revert

@Famlam
Copy link
Collaborator Author

Famlam commented May 19, 2025

Ok, will make the revert commit tonight or Wednesday :)

@Famlam Famlam marked this pull request as draft May 19, 2025 10:30
Famlam added a commit that referenced this pull request May 19, 2025
This reverts commit fb733d5.

See #2510 for details
The numbered versions match the ISO norm
@Famlam
Copy link
Collaborator Author

Famlam commented May 19, 2025

I made the revert PR as #2511 because that was easier. Closing this PR

@Famlam Famlam closed this May 19, 2025
@Famlam Famlam deleted the famlam-nsi-austria branch May 19, 2025 21:23
frodrigo pushed a commit that referenced this pull request May 19, 2025
This reverts commit fb733d5.

See #2510 for details
The numbered versions match the ISO norm
frodrigo pushed a commit that referenced this pull request Jun 17, 2025
This reverts commit fb733d5.

See #2510 for details
The numbered versions match the ISO norm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants