Skip to content

Remove unused maxspeed types for Austria #2504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 17, 2025
Merged

Conversation

wolfbert
Copy link
Contributor

@wolfbert wolfbert commented May 1, 2025

at:urban30 and at:urban40 have been superseded by at:city_limit30 and at:city_limit40 (which will be checked in a separate plugin).

Part of #2503

wolfbert added 5 commits May 1, 2025 21:46
at:urban30 and at:urban40 have been superseded by at:city_limit30 and at:city_limit40 (which will be checked in a separate plugin).
…Austria

Removed unused maxspeed types for Austria
Changed to commonly understood abbreviations
@wolfbert
Copy link
Contributor Author

wolfbert commented May 2, 2025

Changed abbreviations for Austrian provinces to something meaningful. I haven't found any use of them in the code, so hopefully this doesn't have further consequences.

Sorry for not creating a separate pull request, I still have to get used to Github.

@frodrigo
Copy link
Contributor

frodrigo commented May 2, 2025

Changed abbreviations for Austrian provinces to something meaningful. I haven't found any use of them in the code, so hopefully this doesn't have further consequences.

If the abrev are not used in the code there is no impact (not sure about that). But changing the name has lot of impact. It should match the name of the OSM extract provider and update in the Osmose frontend.

Due to side effects
@wolfbert
Copy link
Contributor Author

wolfbert commented May 2, 2025

No problem, have reverted the changes.

@frodrigo frodrigo merged commit 6f3b451 into osmose-qa:dev May 17, 2025
@Famlam
Copy link
Collaborator

Famlam commented May 18, 2025

If the abrev are not used in the code there is no impact (not sure about that).

Sorry, didn't have the time to review, but when I checked what was newly committed I remembered one consequence #2510

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants