Geom refactor #1396
Merged
Geom refactor #1396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves the linestring splitting into its own function split_linestring and add tests. They show that the original function created invalid linestrings in some cases, so this also fixes the algorithm.
Relations consisting of exactly two ways connected end-to-end where one way needs to be turned around to form a real ring were not built correctly. This fixes this problem and adds a lot of tests.
This is to avoid confusion with the equality operator which uses a different logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1394 and another bug. To better debug this and as part of the work we want to do anyway of refactoring the geometry code, I have already refactored some of the code and added tests. The refactored code is certainly not perfect and I expect more iterations until we see clearly how to best separate out the many functions.