Adds algorithm option :modular for Gröbner basis computations #4246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4246 +/- ##
=======================================
Coverage 84.59% 84.59%
=======================================
Files 631 631
Lines 85064 85070 +6
=======================================
+ Hits 71960 71966 +6
Misses 13104 13104
|
afkafkafk13
approved these changes
Oct 25, 2024
HechtiDerLachs
pushed a commit
to HechtiDerLachs/Oscar.jl
that referenced
this pull request
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a first step for enabling multi-modular Gröbner basis computations. It adds the algorithm option
:modularand applies (if possible) either a multi-modular f4 from AlgebraicSolving or a multi-modular Buchberger based on Singular.Following this PR, further implementations in other applicable settings for the multi-modular Buchberger need to be moved from
experimental. Also, discussions about default options need to be discussed and are not part of this PR.