Dimension of an ideal #4244
Draft
Dimension of an ideal #4244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgoettgens
reviewed
Oct 24, 2024
Co-authored-by: Lars Göttgens <lars.goettgens@gmail.com>
lgoettgens
reviewed
Oct 24, 2024
| @@ -1884,8 +1884,13 @@ julia> dim(I) | |||
| if I.dim > -1 | |||
| return I.dim | |||
| end | |||
| is_one(I) && return -1 # Catch a boundary case | |||
There was a problem hiding this comment.
Maybe stupid question: if I remember correctly, this is_one call already computes a groebner basis (possibly via singular). Wouldn't it then be more efficient to use this knowledge in Singular.dimension? Or does AlgebraicSolving.dimension make use of that as well?
There was a problem hiding this comment.
You are right, is_one() computes a GB via Singular. I will work on this tomorrow, there is more that can be optimized, e.g. caching GBs.
|
Let me put this in draft mode, we first need to have #4246 and some discussions on default options before it makes sense to optimize this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows AlgebraicSolving to compute the dimension of an ideal, if applicable.