Some fixes and performance improvements for iso_oscar_gap(::LieAlgebra)
#4227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgoettgens
force-pushed
the
lg/Lie-iso-oscar-gap
branch
from
e821d7d
to
dcbd2b9
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4227 +/- ##
==========================================
- Coverage 84.58% 84.58% -0.01%
==========================================
Files 631 631
Lines 85009 85010 +1
==========================================
- Hits 71908 71907 -1
- Misses 13101 13103 +2
|
HechtiDerLachs
pushed a commit
to HechtiDerLachs/Oscar.jl
that referenced
this pull request
Oct 30, 2024
…ra)` (oscar-system#4227) * Make `_iso_oscar_gap(::AbstractLieAlgeba)` way more efficient * Move root system iso to its own function * Some type stability * Remove some unwanted iso caching
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relevant changes:
_iso_oscar_gap(::AbstractLieAlgebra)now accesses internals ofAbstractLieAlgebra, but this has a >100x performance improvement_iso_oscar_gap(::LinearLieAlgebra)now also transfers the root system (if one is already known)Oscar.iso_oscar_gapnow asserts the return type given in the docstring