Some type stability

oscar-system · Oct 22, 2024 · dcbd2b9 · dcbd2b9
1 parent 68cdc5d
commit dcbd2b9
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/experimental/LieAlgebras/src/iso_oscar_gap.jl b/experimental/LieAlgebras/src/iso_oscar_gap.jl
@@ -56,8 +56,8 @@ function _iso_oscar_gap(LO::AbstractLieAlgebra; set_attributes::Bool=true)
     coeffs_iso(zero(coefficient_ring(LO)))
   ]
 
-  LG = GAP.Globals.LieAlgebraByStructureConstants(
-    codomain(coeffs_iso), GAP.Obj(sc_table_G; recursive=true)
+  LG = GAPWrap.LieAlgebraByStructureConstants(
+    codomain(coeffs_iso), GapObj(sc_table_G; recursive=true)
   )
 
   f, finv = _iso_oscar_gap_lie_algebra_functions(LO, LG, coeffs_iso)

diff --git a/src/GAP/iso_oscar_gap.jl b/src/GAP/iso_oscar_gap.jl
@@ -402,7 +402,7 @@ function _iso_oscar_gap(FO::QQAbField)
 end
 
 """
-    Oscar.iso_oscar_gap(R) -> Map{T, GapObj}
+    Oscar.iso_oscar_gap(R::T) -> Map{T, GapObj}
 
 Return an isomorphism `f` with domain `R`
 and `codomain` a GAP object `S`.
@@ -481,7 +481,7 @@ true
     structure is not fully supported in GAP will likely cause overhead
     at runtime.
 """
-@attr Map function iso_oscar_gap(F)
+@attr Map{T, GapObj} function iso_oscar_gap(F::T) where T
    return _iso_oscar_gap(F)
 end
 

diff --git a/src/GAP/wrappers.jl b/src/GAP/wrappers.jl
@@ -270,6 +270,7 @@ GAP.@wrap LargestMovedPoint(x::Any)::Int
 GAP.@wrap LeftActingDomain(x::GapObj)::GapObj
 GAP.@wrap LetterRepAssocWord(x::GapObj)::GapObj
 GAP.@wrap LibInfoCharacterTable(x::GapObj)::GapObj
+GAP.@wrap LieAlgebraByStructureConstants(x::GapObj, y::GapObj)::GapObj
 GAP.@wrap LinearCharacters(x::GapObj)::GapObj
 GAP.@wrap LinearCombination(x::GapObj, y::GapObj)::GapObj
 GAP.@wrap ListPerm(x::GapObj)::GapObj