Skip to content

Conversation

fingolfin
Copy link
Member

No description provided.

@fingolfin fingolfin requested a review from ThomasBreuer March 21, 2024 01:27
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Merging #982 (544ad3e) into master (32aaa36) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #982      +/-   ##
==========================================
- Coverage   76.73%   76.72%   -0.01%     
==========================================
  Files          51       51              
  Lines        4195     4194       -1     
==========================================
- Hits         3219     3218       -1     
  Misses        976      976              
Files Coverage Δ
src/setup.jl 87.60% <100.00%> (-0.11%) ⬇️

Copy link
Member

@ThomasBreuer ThomasBreuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This solves the problem from the discussion of #975.
(The change assumes that any line that is not a comment line and that contains at least one = character means an assignment to a variable, where the variable name is on the left of the first = and the value is on the right. If this is correct then the code is o.k.)

@fingolfin fingolfin merged commit 98c98c6 into oscar-system:master Mar 22, 2024
@fingolfin fingolfin deleted the mh/read_sysinfo_gap branch March 22, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants