Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to GAP 4.13.0 #975

Merged
merged 3 commits into from
Mar 21, 2024
Merged

Switch to GAP 4.13.0 #975

merged 3 commits into from
Mar 21, 2024

Conversation

fingolfin
Copy link
Member

No description provided.

@fingolfin fingolfin changed the title Prepare for GAP 4.13.0 Switch to GAP 4.13.0 Mar 19, 2024
@fingolfin fingolfin force-pushed the mh/GAP-4.13.0 branch 2 times, most recently from 7b25959 to 39f5d10 Compare March 19, 2024 10:48
Project.toml Outdated Show resolved Hide resolved
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Merging #975 (34056e5) into master (32aaa36) will decrease coverage by 0.93%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #975      +/-   ##
==========================================
- Coverage   76.73%   75.80%   -0.93%     
==========================================
  Files          51       51              
  Lines        4195     4187       -8     
==========================================
- Hits         3219     3174      -45     
- Misses        976     1013      +37     
Files Coverage Δ
gap/systemfile.g 94.44% <100.00%> (ø)
pkg/JuliaExperimental/PackageInfo.g 100.00% <100.00%> (ø)
pkg/JuliaExperimental/gap/numfield.g 95.24% <100.00%> (ø)
pkg/JuliaInterface/PackageInfo.g 90.17% <100.00%> (ø)
src/setup.jl 79.82% <ø> (-7.89%) ⬇️

... and 1 file with indirect coverage changes

@fingolfin fingolfin marked this pull request as ready for review March 19, 2024 22:59
@fingolfin fingolfin requested a review from ThomasBreuer March 19, 2024 22:59
Copy link
Member

@ThomasBreuer ThomasBreuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, as far as I can judge.
Just one possible simplification (see remark).
(And I assume that adjusting sysinfo["GAP_CFLAGS"] and sysinfo["GAP_CXXFLAGS"] had first been changed but now this is not needed anymore.)

src/setup.jl Outdated Show resolved Hide resolved
@fingolfin fingolfin merged commit d797090 into master Mar 21, 2024
14 checks passed
@fingolfin fingolfin deleted the mh/GAP-4.13.0 branch March 21, 2024 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants