-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cloudapi: Add module_hotfixes flag #3831
Conversation
7bbe655
to
0e73782
Compare
0e73782
to
9aeb873
Compare
9aeb873
to
2b6d61c
Compare
You can use images |
I think that it would be good to enable this repo setting also for user-defined sources (repos) on-premise. This means extending: Without this, one won't be able to define 3rd party repos with this option set, which are used for the actual image build. They could only embed repo definitions inside the final image with the option set (this is handled by the BP customization). |
f5968ef
to
cc2c987
Compare
6c000c2
to
24a7339
Compare
7e9ca88
to
a5ee2e7
Compare
All FIPS tests failure has been fixed by PR #3849. Could you please make a rebase? Thanks. |
a5ee2e7
to
4fe5ecd
Compare
4fe5ecd
to
c1cfdfc
Compare
All |
@thozza can you check out the vsphere failures if you see something in there? https://gitlab.com/redhat/services/products/image-builder/ci/osbuild-composer/-/pipelines/1109228638 I can't figure out what's the issue. |
b0b2a56
to
aa6bc9c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
The nightly pipeline failures are unrelated to this PR.
Allow passing module_hotfixes as repo option, it will allow disabling of modularity filtering per repository.
Allow passing module_hotfixes flag through the cloudapi. This will enable depsolving on repositories that might be affected by modularity filtering. Refs HMS-3202
aa6bc9c
to
d128e65
Compare
Thank you for guiding me @thozza ! 👍 |
Allow passing module_hotfixes flag through the cloudapi. This will enable depsolving on repositories that might be affected by modularity filtering.
Refs HMS-3202
Needs osbuild/images#284 to have this flag on all the repositories.
⚠️ currently this includes
osbuild/images
bump, which we want to wait for the release I'm guessing, but apart of that, this is ready for review :)