Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

module-hotfixes #3813

Closed
wants to merge 1 commit into from
Closed

Conversation

croissanne
Copy link
Member

No description provided.

Copy link
Collaborator

@schutzbot schutzbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ This PR introduces changes in at least one manifest (when comparing PR HEAD c8ac21a with the main merge-base 5b19bd6). Please review the changes. The changes can be found in the artifacts of the Manifest-diff job [0] as manifests.diff.

[0] https://gitlab.com/redhat/services/products/image-builder/ci/osbuild-composer/-/jobs/5601919319/artifacts/browse

Copy link
Collaborator

@schutzbot schutzbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ This PR introduces changes in at least one manifest (when comparing PR HEAD c8ac21a with the main merge-base 5b19bd6). Please review the changes. The changes can be found in the artifacts of the Manifest-diff job [0] as manifests.diff.

[0] https://gitlab.com/redhat/services/products/image-builder/ci/osbuild-composer/-/jobs/5601921075/artifacts/browse

@bcl
Copy link
Contributor

bcl commented Nov 27, 2023

I know it's just a draft, for a final version please explain why this is needed -- it's the first time I remember seeing that option and it's not clear to me what it does even after reading the dnf docs :)

@ezr-ondrej
Copy link
Contributor

ezr-ondrej commented Nov 27, 2023

I actually kinda like this "buldoze" solution, just disable modularity completely, but I'm not sure if there are consequences 🤷

I know it's just a draft, for a final version please explain why this is needed -- it's the first time I remember seeing that option and it's not clear to me what it does even after reading the dnf docs :)

It basically ignores that given packages is from disabled modules and installs them anyway (in this case considers them for depsolve)

I dunno where's a dnf-json docs to document this :)

Copy link

This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Dec 28, 2023
@ondrejbudai
Copy link
Member

This was implemented in a better way by #3831.

@ondrejbudai ondrejbudai closed this Jan 2, 2024
@croissanne croissanne deleted the module-hotfixes branch May 15, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants