systemd.unit.create: Add Environment and EnvironmentFile options (HMS-3814) #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcl
previously approved these changes
Apr 9, 2024
I agree, panic calls should be for things that are plainly "illegal" programming-wise, especially now that this is a library. I'd like to do a full sweep of all the panics at some point but for now I'm keeping it consistent. |
|
...aaaand it has conflicts. :( |
See osbuild/osbuild#1684 Signed-off-by: Achilleas Koutsou <achilleas@koutsou.net>
The Environment option in osbuild is now either a string or an array of key-value pairs. Let's just implement the array of key-value pairs here. It supports multiple instances and we don't need to make things complicated here by supporting both. This change modifies all RHEL EC2 and Azure images, but there is no functional change. See osbuild/osbuild#1684 Signed-off-by: Achilleas Koutsou <achilleas@koutsou.net>
Signed-off-by: Achilleas Koutsou <achilleas@koutsou.net>
Signed-off-by: Achilleas Koutsou <achilleas@koutsou.net>
achilleas-k
force-pushed
the
systemd/environment
branch
from
fc1816a
to
af8a5d6
Compare
achilleas-k
force-pushed
the
systemd/environment
branch
from
af8a5d6
to
0a50f5a
Compare
|
The previous osbuild commit I used didn't have a CI build (even though it was the |
Signed-off-by: Achilleas Koutsou <achilleas@koutsou.net>
achilleas-k
force-pushed
the
systemd/environment
branch
from
0a50f5a
to
cd9a4ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
osbuild: new Environment options for systemd.unit.create
See osbuild/osbuild#1684
Signed-off-by: Achilleas Koutsou achilleas@koutsou.net
osbuild: new Environment options for systemd.unit
The Environment option in osbuild is now either a string or an array of
key-value pairs. Let's just implement the array of key-value pairs
here. It supports multiple instances and we don't need to make things
complicated here by supporting both.
This change modifies all RHEL EC2 and Azure images, but there is no
functional change.
See osbuild/osbuild#1684
Signed-off-by: Achilleas Koutsou achilleas@koutsou.net
osbuild: validate env var name in systemd.unit.create
Signed-off-by: Achilleas Koutsou achilleas@koutsou.net
osbuild: validate env var name in systemd.unit
Signed-off-by: Achilleas Koutsou achilleas@koutsou.net