-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failing tests due to string quoting changes in systemd unit files #310
Comments
croissanne
added a commit
to croissanne/cloud-image-val
that referenced
this issue
Apr 16, 2024
Newer versions of osbuild & images quote environment variables in systemd unit files. Fixes osbuild#310
croissanne
added a commit
to croissanne/cloud-image-val
that referenced
this issue
Apr 16, 2024
Newer versions of osbuild & images quote environment variables in systemd unit files. Fixes osbuild#310
croissanne
added a commit
to croissanne/cloud-image-val
that referenced
this issue
Apr 16, 2024
Newer versions of osbuild & images quote environment variables in systemd unit files. Fixes osbuild#310
croissanne
added a commit
to croissanne/cloud-image-val
that referenced
this issue
Apr 16, 2024
Newer versions of osbuild & images quote environment variables in systemd unit files. Fixes osbuild#310
croissanne
added a commit
that referenced
this issue
Apr 16, 2024
Newer versions of osbuild & images quote environment variables in systemd unit files. Fixes #310
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In osbuild/images#567 we made a non-functional change to the way we write systemd unit files. The
Environment
option in the osbuild stage now supports multiple entries. At the same time, we made it so thatkey=value
assignments are quoted, which makes it easier to work with values with spaces.From the systemd-exec man page:
I think this change made CIV start failing to validate because it expects the unquoted strings in some of the cloud systemd units like here:
cloud-image-val/test_suite/generic/test_generic.py
Line 716 in 32b5842
The line now is
Environment="NM_CLOUD_SETUP_AZURE=yes"
instead ofEnvironment=NM_CLOUD_SETUP_AZURE=yes
.The text was updated successfully, but these errors were encountered: