Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distro/fedora_ng: add a fedora ng distro #14

Closed
wants to merge 3 commits into from

Conversation

supakeen
Copy link
Member

@supakeen supakeen commented Jul 11, 2023

This PR is the continuation of osbuild/osbuild-composer#3545. Instead of ripping out distro/fedora it introduces a new distro called fedora_ng (for next generation) which has no packages configured, all configuration is to happen in blueprints.

This is to support building Fedora spins and editions as defined in https://github.com/osbuild/fedora-blueprints

Necessary image types for fedora_ng:

  • Raw (disk-raw)
  • Live ISO (iso-live)

Sidequests:

  • Rename image/live to image/disk and all relevant liveImage -> diskImage to better describe what it actually does.

Documentation:

  • Write down what the corePackageSet is.
  • Write down what each image type adds to the corePackageSet.
  • Write down what each image type does to the tree.

Questions:

  • Do we need syslinux-nonlinux in the package set for iso-live? It might be a build package only as we seem to only copy it.

@achilleas-k
Copy link
Member

I'm very much on board with the idea of having it separate (at least initially), but I wonder if the name would be confusing as it's the old Fedora name? It's a good name and I don't have a better alternative though.

@teg
Copy link
Member

teg commented Jul 19, 2023

What's the plan for when this lands? Will we keep two fedora distros or will one be built on top of the other?

If the forever, why is this done as a separate distro rather than options on the existing one?

@supakeen
Copy link
Member Author

supakeen commented Jul 19, 2023

What's the plan for when this lands? Will we keep two fedora distros or will one be built on top of the other?

What's the plan for when this lands? Will we keep two fedora distros or will one be built on top of the other?

If the forever, why is this done as a separate distro rather than options on the existing one?

The plan is to eventually have this become fedora but this will be a slow and over-time process. Initially fedora-core (I'm renaming it) will only define the disk-raw and iso-live image type as necessary for Fedora.

@supakeen supakeen changed the title distro/fedora_core: add a fedora core distro distro/fedora_ng: add a fedora ng distro Jul 19, 2023
@supakeen supakeen force-pushed the fedora-base branch 2 times, most recently from 9612d8b to c98ba22 Compare July 20, 2023 15:45
@supakeen supakeen force-pushed the fedora-base branch 6 times, most recently from 2d1f710 to 3e428f5 Compare July 27, 2023 14:17
This distribution needs everything to be defined in blueprints.
Renames the `image/live` to `image/disk`. Als renames all image types in
all distros to be called `diskImage` instead of `liveImage`.

This much better describes what the old `liveImage` did (build various
disk images).
This creates things that start in `live` mode, for use on ISOs.
@github-actions
Copy link

github-actions bot commented Sep 8, 2023

This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Sep 8, 2023
@github-actions
Copy link

This PR was closed because it has been stalled for 30+7 days with no activity.

@github-actions github-actions bot closed this Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants