fix: add namespace to remaining poddisruptionbudget helm templates - #888
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThree Helm chart PodDisruptionBudget templates (hydra-maester, kratos, oathkeeper-maester) are updated so metadata.namespace is conditionally rendered from .Release.Namespace when that value is set. ChangesPDB Namespace Conditional Rendering
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related issues
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: somaz <genius5711@gmail.com>
cd68a5f to
312afe1
Compare
|
Hi @Demonsthere — friendly ping on this one. All checks are green and there are no conflicts. This is the follow-up to #885 (hydra), covering the remaining charts that still template a PodDisruptionBudget without a namespace: hydra-maester, kratos and oathkeeper-maester. It does not overlap with #885 or with the open #883. Happy to rebase or split it up if that would help. Thanks! |
|
Hi there! |
The PodDisruptionBudget templates for kratos, hydra-maester, and
oathkeeper-maester don't set
metadata.namespace, so the PDB doesn'tinherit the release namespace. This completes the same fix already
merged for hydra (#885) and in progress for oathkeeper (#883); keto
already has it.
Same guard as #885:
Validation:
helm templateon all three charts withpdb.enabled=truerendersnamespace: <release-namespace>on the PDB.namespace line.
related: #882, #884
Summary by CodeRabbit