Skip to content

fix: add namespace to oathkeeper poddisruptionbudget helm template - #883

Merged
Demonsthere merged 1 commit into
ory:masterfrom
naohiroo:fix/oathkeeper-add-namespace-to-poddisruptionbudget
Jul 31, 2026
Merged

fix: add namespace to oathkeeper poddisruptionbudget helm template#883
Demonsthere merged 1 commit into
ory:masterfrom
naohiroo:fix/oathkeeper-add-namespace-to-poddisruptionbudget

Conversation

@naohiroo

@naohiroo naohiroo commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Related Issue or Design Document

#882

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact security@ory.com) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

Summary by CodeRabbit

  • Bug Fixes
    • Pod disruption budgets now include the release namespace when available, ensuring they’re created in the correct location.

@coderabbitai

coderabbitai Bot commented Jul 1, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 4a5681a3-0afa-4826-a7b4-347c8f77659c

📥 Commits

Reviewing files that changed from the base of the PR and between f9ca9d7 and e6b13d0.

📒 Files selected for processing (1)
  • helm/charts/oathkeeper/templates/pdb.yaml
✅ Files skipped from review due to trivial changes (1)
  • helm/charts/oathkeeper/templates/pdb.yaml

📝 Walkthrough

Walkthrough

The oathkeeper PodDisruptionBudget Helm template now conditionally renders metadata.namespace from .Release.Namespace when it is set. The template previously included only metadata.name.

Changes

PDB Namespace Fix

Layer / File(s) Summary
Conditional namespace in PDB metadata
helm/charts/oathkeeper/templates/pdb.yaml
Adds a conditional namespace: {{ .Release.Namespace }} field to the PodDisruptionBudget metadata block.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related issues

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the change: adding the namespace to the Oathkeeper PodDisruptionBudget Helm template.
Description check ✅ Passed The description includes the bug-fix context, related issue, and checklist, so it is mostly complete despite some unchecked items.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@naohiroo naohiroo changed the title fix: add namespace to oathkeeper poddisruptionbudget helm template (#… fix: add namespace to oathkeeper poddisruptionbudget helm template Jul 1, 2026
@naohiroo
naohiroo marked this pull request as ready for review July 1, 2026 11:38
@Demonsthere

Copy link
Copy Markdown
Collaborator

please rebase, as i had to fix the kubescape scan issue on master :)

@naohiroo
naohiroo force-pushed the fix/oathkeeper-add-namespace-to-poddisruptionbudget branch from f9ca9d7 to e6b13d0 Compare July 3, 2026 05:24
@naohiroo

naohiroo commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

Thank you for the fix. I've rebased my branch on master.

@naohiroo

Copy link
Copy Markdown
Contributor Author

@Demonsthere Could you please take another look when you have a chance?

@Demonsthere
Demonsthere merged commit 19b04f7 into ory:master Jul 31, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants