feat: Enforce pkce only public client #1874
Merged
+27
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeneasr
reviewed
May 26, 2020
There was a problem hiding this comment.
Looks good! You still need to add it to the config schema: https://github.com/ory/hydra/blob/master/.schema/config.schema.json#L720
sawadashota
force-pushed
the
enforce_pkce_only_public_client
branch
from
f7d4180
to
a111e58
Compare
aeneasr
reviewed
May 26, 2020
sawadashota
force-pushed
the
enforce_pkce_only_public_client
branch
from
3ca4b38
to
1f46722
Compare
sawadashota
commented
May 27, 2020
sawadashota
commented
May 27, 2020
|
@aeneasr I've done! CI job Could you review this PR again? |
will resolve the nancy issue! |
aeneasr
reviewed
May 27, 2020
go.mod
Outdated
| @@ -20,34 +21,37 @@ require ( | |||
| github.com/google/uuid v1.1.1 | |||
| github.com/gorilla/securecookie v1.1.1 | |||
| github.com/gorilla/sessions v1.2.0 | |||
| github.com/gorilla/websocket v1.4.2 // indirect | |||
Signed-off-by: sawadashota <xiootas@gmail.com>
Signed-off-by: sawadashota <xiootas@gmail.com>
Signed-off-by: sawadashota <xiootas@gmail.com>
Signed-off-by: sawadashota <xiootas@gmail.com>
Signed-off-by: sawadashota <xiootas@gmail.com>
Signed-off-by: sawadashota <xiootas@gmail.com>
sawadashota
force-pushed
the
enforce_pkce_only_public_client
branch
from
e99ffe5
to
d747d7b
Compare
|
Now all tests are passed! |
|
Thank you for the great work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Enforce pkce only public client.
Checklist
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
security@ory.sh) from the maintainers to push
the changes.
works.
Further comments