fix: Rename config name for enforced for public clients

Signed-off-by: sawadashota <xiootas@gmail.com>
ory · May 27, 2020 · 3ca4b38 · 3ca4b38
1 parent 12c1fa4
commit 3ca4b38
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 6 deletions.
diff --git a/.schema/config.schema.json b/.schema/config.schema.json
@@ -724,7 +724,7 @@
                 true
               ]
             },
-            "enforced_public_clients": {
+            "enforced_for_public_clients": {
               "type": "boolean",
               "description": "Sets whether PKCE should be enforced for public clients.",
               "examples": [

diff --git a/docs/docs/reference/configuration.md b/docs/docs/reference/configuration.md
@@ -998,7 +998,7 @@ oauth2:
     #
     # Examples:
     # - true
-    enforced_public_clients: true
+    enforced_for_public_clients: true
 
 
 ## secrets ##

diff --git a/driver/configuration/provider_viper.go b/driver/configuration/provider_viper.go
@@ -71,7 +71,7 @@ const (
 	ViperKeyAccessTokenStrategy            = "strategies.access_token"
 	ViperKeySubjectIdentifierAlgorithmSalt = "oidc.subject_identifiers.pairwise.salt"
 	ViperKeyPKCEEnforced                   = "oauth2.pkce.enforced"
-	ViperKeyPKCEEnforcedPublicClients      = "oauth2.pkce.enforced_public_clients"
+	ViperKeyPKCEEnforcedForPublicClients   = "oauth2.pkce.enforced_for_public_clients"
 	ViperKeyLogLevel                       = "log.level"
 )
 
@@ -444,5 +444,5 @@ func (v *ViperProvider) PKCEEnforced() bool {
 }
 
 func (v *ViperProvider) EnforcePKCEForPublicClients() bool {
-	return viperx.GetBool(v.l, ViperKeyPKCEEnforcedPublicClients, false, "OAUTH2_PKCE_ENFORCED_PUBLIC_CLIENTS")
+	return viperx.GetBool(v.l, ViperKeyPKCEEnforcedForPublicClients, false, "OAUTH2_PKCE_ENFORCED_FOR_PUBLIC_CLIENTS")
 }
diff --git a/internal/.hydra.yaml b/internal/.hydra.yaml
@@ -104,7 +104,7 @@ oauth2:
       cost: 20
   pkce:
     enforced: true
-    enforced_public_clients: true
+    enforced_for_public_clients: true
 
 secrets:
   system:

diff --git a/internal/config/config.yaml b/internal/config/config.yaml
@@ -377,7 +377,7 @@ oauth2:
     # Set this to true if you want PKCE to be enforced for all clients.
     enforced: false
     # Set this to true if you want PKCE to be enforced for public clients.
-    enforced_public_clients: false
+    enforced_for_public_clients: false
   session:
     # store encrypted data in database, default true
     encrypt_at_rest: true