Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

strategies.access_token missing in configuration JSON schema #1830

Merged
merged 3 commits into from
Apr 30, 2020
Merged

strategies.access_token missing in configuration JSON schema #1830

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f71e34f
fix: access token strategy missing
trecloux Apr 27, 2020
85ac27e
fix: no default value in schema to keep env var
trecloux Apr 28, 2020
f22aa0a
fix: add test on access token strategy configuration
trecloux Apr 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .schema/config.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -612,6 +612,14 @@
"DEPRECATED_HIERARCHICAL_SCOPE_STRATEGY"
],
"default": "wildcard"
},
"access_token": {
"type": "string",
"description": "Defines access token type. jwt is a bad idea, see https://www.ory.sh/docs/hydra/advanced#json-web-tokens",
"enum": [
"opaque",
"jwt"
]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
]
"default": "opaque",
]

}
}
},
Expand Down
1 change: 1 addition & 0 deletions driver/configuration/provider_viper_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,7 @@ func TestViperProviderValidates(t *testing.T) {

// strategies
assert.Equal(t, "exact", c.ScopeStrategy())
assert.Equal(t, "opaque", c.AccessTokenStrategy())

// ttl
assert.Equal(t, 2*time.Hour, c.ConsentRequestMaxAge())
Expand Down
1 change: 1 addition & 0 deletions internal/.hydra.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ urls:

strategies:
scope: exact
access_token: opaque

ttl:
login_consent_request: 2h
Expand Down