Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strategies.access_token missing in configuration JSON schema #1830

Merged

Conversation

trecloux
Copy link
Contributor

Proposed changes

Configuration JSON schema did not include strategies.access_token.

Checklist

  • I have read the contributing guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

@CLAassistant
Copy link

CLAassistant commented Apr 27, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one minor change!

"enum": [
"opaque",
"jwt"
]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
]
"default": "opaque",
]

@aeneasr
Copy link
Member

aeneasr commented Apr 28, 2020

Oh and could you please add a test for https://github.com/ory/hydra/blob/master/driver/configuration/provider.go#L33 here: https://github.com/ory/hydra/blob/master/driver/configuration/provider_viper_test.go#L214 ? :)

@trecloux
Copy link
Contributor Author

I added the test, thanks for the hint.

Do you want me to squash my commits ?

@aeneasr
Copy link
Member

aeneasr commented Apr 30, 2020

No that's fine! Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants