Skip to content

fix: resolve gosec lint failures (G703, G117, G704) #1985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TerryHowe wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: resolve gosec lint failures (G703, G117, G704) #1985

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion cmd/oras/internal/display/metadata/tree/discover_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ func TestDiscoverHandler_OnDiscovered(t *testing.T) {
if err != nil {
t.Fatalf("Failed to create temporary file: %v", err)
}
defer func() { _ = os.Remove(tmp.Name()) }()
defer func() { _ = tmp.Close() }()

h := NewDiscoverHandler(&buf, path, subjectDesc, true, tmp)
Expand Down
2 changes: 1 addition & 1 deletion cmd/oras/internal/option/remote.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ type Remote struct {
Configs []string
Username string
secretFromStdin bool
Secret string
Secret string //nolint:gosec // G117: not a hardcoded secret, this is a CLI option field
flagPrefix string

resolveFlag []string
Expand Down
4 changes: 2 additions & 2 deletions internal/crypto/certificate_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ func TestLoadCertPool(t *testing.T) {
t.Fatalf("unexpected error: %v", err)
}
client := &http.Client{}
resp, err := client.Do(req)
resp, err := client.Do(req) //nolint:gosec // G704: URL is from local httptest.Server
if err == nil {
resp.Body.Close()
t.Fatalf("expecting TLS check failure error but didn't get one")
Expand All @@ -53,7 +53,7 @@ func TestLoadCertPool(t *testing.T) {
t.Fatalf("unexpected error: %v", err)
}
client = &http.Client{Transport: tp}
resp, err = client.Do(req)
resp, err = client.Do(req) //nolint:gosec // G704: URL is from local httptest.Server
if err != nil {
t.Fatalf("failed to trust the self signed pem: %v", err)
}
Expand Down
Loading