fix: resolve gosec lint failures (G703, G117, G704)#1985
Open
TerryHowe wants to merge 1 commit intooras-project:mainfrom
Open
fix: resolve gosec lint failures (G703, G117, G704)#1985TerryHowe wants to merge 1 commit intooras-project:mainfrom
TerryHowe wants to merge 1 commit intooras-project:mainfrom
Conversation
- Remove unnecessary os.Remove in discover_test.go since t.TempDir() auto-cleans (G703) - Add nolint directive for Secret field in Remote struct (G117) - Add nolint directives for test httptest.Server client.Do calls (G704) Signed-off-by: Terry Howe <terrylhowe@gmail.com>
TerryHowe
requested review from
Wwwsylvia,
sajayantony and
shizhMSFT
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1985 +/- ##
==========================================
+ Coverage 87.14% 87.18% +0.03%
==========================================
Files 143 143
Lines 5539 5539
==========================================
+ Hits 4827 4829 +2
+ Misses 425 423 -2
Partials 287 287 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
os.Removeindiscover_test.gosincet.TempDir()auto-cleans (G703)Secretfield inRemotestruct — it's a CLI option, not a hardcoded secret (G117)client.Do(req)calls incertificate_test.go— URLs come from localhttptest.Server(G704)Resolves #1984
Signed-off-by: Terry Howe terrylhowe@gmail.com