Skip to content

Remove t3 channel in IT tests and add it to separate IT class. #2036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Nov 10, 2020
Merged
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
902e4ee
Modifying the tests to use default channel for wlst deployment
sankarpn Nov 4, 2020
0010edf
add debug statements
sankarpn Nov 4, 2020
110e22c
Merge branch 'develop' into t3channelfix
sankarpn Nov 5, 2020
3930956
use pod host name instead of external host and nodePort
sankarpn Nov 5, 2020
b7b1fac
use admin server internal pod name and service port
sankarpn Nov 6, 2020
2df3f13
Merge branch 'develop' of https://github.com/oracle/weblogic-kubernet…
sankarpn Nov 6, 2020
61cc5df
remove debug statements
sankarpn Nov 6, 2020
23665d0
add t3channel test in ItDedicatedMode.java
sankarpn Nov 6, 2020
f37b6a5
use adminserverpod and default service port
sankarpn Nov 6, 2020
76fafdc
pass the file name
sankarpn Nov 6, 2020
8793fc8
fix getting service port
sankarpn Nov 6, 2020
060d8ef
add t3channel
sankarpn Nov 6, 2020
c30adcb
Merge branch 'develop' of https://github.com/oracle/weblogic-kubernet…
sankarpn Nov 9, 2020
7ef7353
fix getting servicve node port
sankarpn Nov 9, 2020
3268e9a
correct typo
sankarpn Nov 9, 2020
aff6675
move the t3 channel test to separate it class
sankarpn Nov 9, 2020
742da59
install operator
sankarpn Nov 9, 2020
16fe424
exclude ItT3Channel from parallel runs
sankarpn Nov 10, 2020
2b99fdf
merge develop branch
sankarpn Nov 10, 2020
f7a8084
exclude t3channel test in parallel runs
sankarpn Nov 10, 2020
a496aa1
rollback changes to kindtest.sh
sankarpn Nov 10, 2020
00bb855
fix
sankarpn Nov 10, 2020
da0172e
Merge branch 'develop' into t3channelfix
sankarpn Nov 10, 2020
03a80bf
exclude t3channel test in parallel run
sankarpn Nov 10, 2020
34e3095
fix typo
sankarpn Nov 10, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add t3channel
  • Loading branch information
sankarpn committed Nov 6, 2020
commit 060d8ef7b6a789d4f08c20abf1bb909d9fe6107c
Original file line number Diff line number Diff line change
Expand Up @@ -470,7 +470,10 @@ public void testAdminServerT3Channel() {
.adminService(new AdminService()
.addChannelsItem(new Channel()
.channelName("default")
.nodePort(0))))
.nodePort(0))
.addChannelsItem(new Channel()
.channelName("T3Channel")
.nodePort(t3ChannelPort))))
.addClustersItem(new Cluster() //cluster
.clusterName(clusterName)
.replicas(replicaCount)
Expand All @@ -490,17 +493,17 @@ public void testAdminServerT3Channel() {
}

// deploy application and verify all servers functions normally
logger.info("Getting node port for default channel");
int defaultChannelNodePort = assertDoesNotThrow(()
-> getServiceNodePort(domain1Namespace, getExternalServicePodName(adminServerPodName), "t3Channel"),
"Getting admin server default port failed");
logger.info("techannel channel node port: {0}", defaultChannelNodePort);
assertNotEquals(-1, defaultChannelNodePort, "admin server t3ChannelNodePort is not valid");
logger.info("Getting node port for T3 channel");
int t3ChannelNodePort = assertDoesNotThrow(()
-> getServiceNodePort(domain1Namespace, getExternalServicePodName(adminServerPodName), "t3channel"),
"Getting admin server t3channel node port failed");
logger.info("techannel channel node port: {0}", t3ChannelNodePort);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
logger.info("techannel channel node port: {0}", t3ChannelNodePort);
logger.info("t3channel channel node port: {0}", t3ChannelNodePort);

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

assertNotEquals(-1, t3ChannelNodePort, "admin server t3ChannelNodePort is not valid");

//deploy clusterview application
logger.info("Deploying clusterview app {0} to cluster {1}",
clusterViewAppPath, clusterName);
deployUsingWlst(adminServerPodName, Integer.toString(defaultChannelNodePort),
deployUsingWlst(adminServerPodName, Integer.toString(t3ChannelNodePort),
ADMIN_USERNAME_DEFAULT, ADMIN_PASSWORD_DEFAULT, adminServerName + "," + clusterName, clusterViewAppPath,
domain1Namespace);

Expand Down