Skip to content

Remove t3 channel in IT tests and add it to separate IT class. #2036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Nov 10, 2020
Merged

Remove t3 channel in IT tests and add it to separate IT class. #2036

merged 25 commits into from
Nov 10, 2020

Conversation

sankarpn
Copy link
Member

@sankarpn sankarpn commented Nov 6, 2020 •
edited
Loading

  • This PR removes the t3 channel exposed in all IT classes due to intermittent failures caused by port conflict.
  • Instead a separate test to expose t3 channel is added to the IT class ItT3Channel.java

Full test suite results
https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-kind-new/3076/testReport/oracle.weblogic.kubernetes/

xiancao
xiancao reviewed Nov 7, 2020
View reviewed changes
Copy link
Member

@xiancao xiancao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both Jenkins runs failed at oracle.weblogic.kubernetes.ItExternalRmiTunneling.testExternalRmiAccessThruHttpsTunneling. Is this expected?

vanajamukkara
vanajamukkara suggested changes Nov 9, 2020
View reviewed changes
integration-tests/src/test/java/oracle/weblogic/kubernetes/ItDedicatedMode.java Outdated
@@ -289,6 +326,197 @@ public void testDedicatedModeNoCrd() {
}
}

/**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add t3channel to the existing MII domain used in the dedicated mode tests and use that to deploy the application using WLST instead of adding new domain? It saves time by not bringing up a new domain.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want to modify the common model file used for this image MII_BASIC_IMAGE_NAME + ":" + MII_BASIC_IMAGE_TAG because it is shared by many tests.
Since anyway this test is running alone, the time it take to run this test shouldn't matter IMO.

integration-tests/src/test/java/oracle/weblogic/kubernetes/ItDedicatedMode.java Outdated
@@ -397,6 +625,45 @@ private void verifyDomainNotRunning(String domainNamespace) {
}
}

private static void verifyMemberHealth(String adminServerPodName, List<String> managedServerNames,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move this into an util class

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method uses a specific app deployed in the test method. Its not a member for util class.

integration-tests/src/test/java/oracle/weblogic/kubernetes/ItDedicatedMode.java Outdated
int t3ChannelNodePort = assertDoesNotThrow(()
-> getServiceNodePort(domain1Namespace, getExternalServicePodName(adminServerPodName), "t3channel"),
"Getting admin server t3channel node port failed");
logger.info("techannel channel node port: {0}", t3ChannelNodePort);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
logger.info("techannel channel node port: {0}", t3ChannelNodePort);
logger.info("t3channel channel node port: {0}", t3ChannelNodePort);

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@sankarpn
Copy link
Member Author

sankarpn commented Nov 9, 2020

Both Jenkins runs failed at oracle.weblogic.kubernetes.ItExternalRmiTunneling.testExternalRmiAccessThruHttpsTunneling. Is this expected?

Thanks for pointing out. Fixed it. The ItExternalRmiTunneling was using a wrong api to get the service port and the test was failing intermittently. Updated the test to use correct api.

@sankarpn sankarpn changed the title Remove t3 channel in IT tests and add it to ItDedicatedMode test class Remove t3 channel in IT tests and add it to separate IT class. Nov 9, 2020
vanajamukkara
vanajamukkara approved these changes Nov 9, 2020
View reviewed changes
Copy link
Member

@vanajamukkara vanajamukkara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG.

anpanigr
anpanigr reviewed Nov 10, 2020
View reviewed changes
Copy link
Member

@anpanigr anpanigr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to modify the kindtest.sh to exclude ItT3Channel test in Parallel run and include it in sequential run.

anpanigr
anpanigr approved these changes Nov 10, 2020
View reviewed changes
Copy link
Member

@anpanigr anpanigr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rjeberhard rjeberhard merged commit c990587 into develop Nov 10, 2020
@rjeberhard rjeberhard deleted the t3channelfix branch January 5, 2021 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anpanigr anpanigr anpanigr approved these changes

@vanajamukkara vanajamukkara vanajamukkara approved these changes

@maggiehe00 maggiehe00 Awaiting requested review from maggiehe00

@hzhao-github hzhao-github Awaiting requested review from hzhao-github

@xiancao xiancao Awaiting requested review from xiancao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sankarpn @anpanigr @xiancao @vanajamukkara @rjeberhard