Fix last super spec #2104
Merged
Fix last super spec #2104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eregon
reviewed
Sep 19, 2020
|
|
||
| final Object[] restArgs; | ||
|
|
||
| if (restArg instanceof RubyArray) { |
There was a problem hiding this comment.
Should we profile this condition (with ConditionProfile)?
There was a problem hiding this comment.
Could do - but I'll be doing a check of the performance of super after the specs pass so I'll update it then.
There was a problem hiding this comment.
I'd rather do it eagerly if you don't mind.
I think in general we currently profile every condition unless it folds at PE time or known to be worthless to profile.
I can also do it when integrating the PR.
There was a problem hiding this comment.
Sure you can do it then - there's a couple of unprofiled branches in this method then.
There was a problem hiding this comment.
Which other branches? restArgIndex is PE constant.
Co-authored-by: Benoit Daloze <eregontp@gmail.com>
eregon
approved these changes
Sep 19, 2020
graalvmbot
pushed a commit
that referenced
this pull request
Sep 23, 2020
PullRequest: truffleruby/1994
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress towards #2103.
Shopify#1.