Fix the last few super issues

[chrisseaton]

I'm keen to fix the last few super issues for an experiment at Shopify

We're got one failing spec:

truffleruby/spec/tags/language/super_tags.txt

Line 1 in 2b84599

fails:The super keyword wraps into array and passes along reassigned rest args with non-array scalar value

But quite a lot of failing MRI tests:

truffleruby/test/mri/excludes/TestSuper.rb

Lines 1 to 10 in 2b84599

	exclude :test_define_method, "needs investigation"
	exclude :test_super_in_instance_eval, "needs investigation"
	exclude :test_super_in_instance_eval_with_define_method, "needs investigation"
	exclude :test_super_in_module_unbound_method, "needs investigation"
	exclude :test_super_in_orphan_block_with_instance_eval, "needs investigation"
	exclude :test_double_include, "needs investigation"
	exclude :test_double_include2, "needs investigation"
	exclude :test_from_eval, "needs investigation"
	exclude :test_super_in_BEGIN, "needs investigation"
	exclude :test_super_with_modified_rest_parameter, "needs investigation"

[chrisseaton]

Dividing up the remaining tests:

These seem to be about methods knowing where they're defined:

• test_define_method
• test_super_in_instance_eval
• test_super_in_instance_eval_with_define_method
• test_super_in_module_unbound_method
• test_super_in_orphan_block_with_instance_eval
• test_super_in_BEGIN

These are possibly about scope:

• test_double_include
• test_double_include2

Eval:

• test_from_eval

[eregon]

I'm not sure how much the corner cases in MRI tests matter in practice (e.g. super inside *eval seems already unlikely), but up to you if you want to fix them.

[HoneyryderChuck]

I've started testing one of my gems against truffleruby and I'm getting a lot of errors which have to do with super: https://gitlab.com/honeyryderchuck/httpx/-/jobs/770843884 . Is it part of this issue?

The call goes like this:

class Body
      class << self
        def new(*, options)
          return options.body if options.body.is_a?(self)

          super # blow up here
        end
      end

[eregon]

@HoneyryderChuck That sounds rather unlikely, the cases mentioned here are all weird edge cases which seem unlikely to happen in real code, like

truffleruby/test/mri/tests/ruby/test_super.rb

Lines 332 to 337 in e751e66

	def foo
	x = Object.new
	x.instance_eval do
	lambda { super() }
	end
	end

In any case, could you file a separate issue to track that?
*, options could be a pattern TruffleRuby doesn't handle correctly for super yet.