Fix feature variable accessor default value #113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
oakbani
commented
Apr 5, 2018
| @@ -1436,7 +1436,7 @@ def test_get_feature_variable_boolean(self): | |||
|
|
|||
| mock_logger.assert_called_once_with( | |||
| enums.LogLevels.INFO, | |||
| 'Value for variable "is_working" of feature flag "test_feature_in_experiment" is true for user "test_user".' | |||
| 'Value for variable "is_working" for variation "variation" is "true".' | |||
There was a problem hiding this comment.
- feature_flag removed as we don't have feature key reference in the new method where we have moved this log message. Additionally, in logging mode logs mentioning feature keys precede this log so no need of it.
- user_id same, not available. And the message sort of implied that selection of value somehow depends on the user ID which isn't true.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please note that we check for 'featureEnabled' flag only in the method 'isFeatureEnabled'. So this flag makes no difference in any of the variable accessor methods.
The issue at hand was that variations, which have an empty 'variables' node, didn't get included in 'variation_variable_usage_map'. This resulted in https://github.com/optimizely/python-sdk/blob/master/optimizely/project_config.py#L435 case when detailed logs were inspected.
Changes in place: