Skip to content

Commit 9bc9918

Browse files
Remove sorting
1 parent 05ea76e commit 9bc9918

File tree

2 files changed

+1
-25
lines changed

2 files changed

+1
-25
lines changed

optimizely/optimizely.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -409,7 +409,7 @@ def get_enabled_features(self, user_id, attributes=None):
409409
attributes: Dict representing user attributes.
410410
411411
Returns:
412-
A sorted list of the keys of the features that are enabled for the user.
412+
A list of the keys of the features that are enabled for the user.
413413
"""
414414

415415
enabled_features = []
@@ -421,7 +421,6 @@ def get_enabled_features(self, user_id, attributes=None):
421421
if self.is_feature_enabled(feature.key, user_id, attributes):
422422
enabled_features.append(feature.key)
423423

424-
enabled_features.sort()
425424
return enabled_features
426425

427426
def get_feature_variable_boolean(self, feature_key, variable_key, user_id, attributes=None):

tests/test_optimizely.py

Lines changed: 0 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -1387,29 +1387,6 @@ def side_effect(*args, **kwargs):
13871387
mock_is_feature_enabled.assert_any_call('test_feature_in_group', 'user_1', None)
13881388
mock_is_feature_enabled.assert_any_call('test_feature_in_experiment_and_rollout', 'user_1', None)
13891389

1390-
def test_get_enabled_features_returns_a_sorted_list(self):
1391-
""" Test that get_enabled_features returns a sorted list of enabled feature keys. """
1392-
1393-
opt_obj = optimizely.Optimizely(json.dumps(self.config_dict_with_features))
1394-
1395-
with mock.patch('optimizely.optimizely.Optimizely.is_feature_enabled',
1396-
return_value=True) as mock_is_feature_enabled:
1397-
received_features = opt_obj.get_enabled_features('user_1')
1398-
1399-
mock_is_feature_enabled.assert_any_call('test_feature_in_experiment', 'user_1', None)
1400-
mock_is_feature_enabled.assert_any_call('test_feature_in_rollout', 'user_1', None)
1401-
mock_is_feature_enabled.assert_any_call('test_feature_in_group', 'user_1', None)
1402-
mock_is_feature_enabled.assert_any_call('test_feature_in_experiment_and_rollout', 'user_1', None)
1403-
1404-
expected_sorted_features = [
1405-
'test_feature_in_experiment',
1406-
'test_feature_in_experiment_and_rollout',
1407-
'test_feature_in_group',
1408-
'test_feature_in_rollout'
1409-
]
1410-
1411-
self.assertEqual(expected_sorted_features, received_features)
1412-
14131390
def test_get_enabled_features__invalid_object(self):
14141391
""" Test that get_enabled_features returns empty list if Optimizely object is not valid. """
14151392

0 commit comments

Comments
 (0)