Skip to content

[FSSDK-9506] Allow any polling interval but implement warning log #841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 34 commits into from
Aug 3, 2023
Merged

[FSSDK-9506] Allow any polling interval but implement warning log #841

merged 34 commits into from
Aug 3, 2023

Conversation

mikechu-optimizely
Copy link
Contributor

Summary

  • Remove 1 second polling floor to allow datafile polling at any frequency
  • For intervals under 30 seconds, log a warning
  • Add JSDoc around updateInterval and DEFAULT constants for clarity
  • Added dev container and supporting configs
  • Light formatting updates
  • Updates to package-lock

Test plan

  • Added a new unit test file httpPollingDatafileManagerPolling to test polling & warning.
  • Existing unit & e2e tests should pass

Issues

@mikechu-optimizely mikechu-optimizely requested a review from a team as a code owner August 1, 2023 13:16
@coveralls
Copy link

coveralls commented Aug 1, 2023 •
edited
Loading

Coverage Status

coverage: 90.528% (+0.007%) from 90.521% when pulling 00b7966 on mike/polling-warning into 2f892be on master.

@mikechu-optimizely mikechu-optimizely mentioned this pull request Aug 2, 2023
Closed
@mikechu-optimizely mikechu-optimizely removed the request for review from Mat001 August 2, 2023 20:54
raju-opti
raju-opti reviewed Aug 3, 2023
View reviewed changes
Copy link
Contributor

@raju-opti raju-opti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mikechu-optimizely mikechu-optimizely merged commit bc51f5d into master Aug 3, 2023
@mikechu-optimizely mikechu-optimizely deleted the mike/polling-warning branch August 3, 2023 14:31
@mikechu-optimizely mikechu-optimizely mentioned this pull request Aug 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raju-opti raju-opti raju-opti approved these changes

Assignees

@mikechu-optimizely mikechu-optimizely

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikechu-optimizely @coveralls @raju-opti