Skip to content

[FSSDK-8910] Adding devcontainer support #833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

[FSSDK-8910] Adding devcontainer support #833

wants to merge 5 commits into from

Conversation

mikechu-optimizely
Copy link
Contributor

@mikechu-optimizely mikechu-optimizely commented Jun 28, 2023 •
edited
Loading

Summary

  • During my help investigating, I pulled the SDK to explore. I'm isolating into a dev container so my package.json scripts run correctly on Windows.

Test plan

  • No primary code changes. All existing unit and e2e tests should pass.

Issues

  • FSSDK-8910

@mikechu-optimizely mikechu-optimizely requested a review from a team as a code owner June 28, 2023 15:26
@coveralls
Copy link

Coverage Status

coverage: 90.515%. remained the same when pulling c56fd63 on mike/devcontainer-setup into 2f75caf on master.

raju-opti
raju-opti approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@raju-opti raju-opti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mikechu-optimizely
Copy link
Contributor Author

This is being included in #841

@mikechu-optimizely mikechu-optimizely deleted the mike/devcontainer-setup branch August 24, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raju-opti raju-opti raju-opti approved these changes

Assignees

@mikechu-optimizely mikechu-optimizely

Labels
abandoned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikechu-optimizely @coveralls @raju-opti