Skip to content

Conversation

@opti-jnguyen
Copy link
Contributor

@opti-jnguyen opti-jnguyen commented Apr 13, 2023

Summary

Addresses various FSC failures from CI/CD https://github.com/optimizely/fullstack-sdk-compatibility-suite/actions/runs/4673470186/jobs/8297872757

Test plan

All existing tests should pass, new unit tests should be made as needed, FSC should fail less afterwards.

Issues

FSSDK-9114

@coveralls
Copy link

coveralls commented Apr 13, 2023

Coverage Status

Coverage: 90.557% (+0.04%) from 90.52% when pulling 43ee9f6 on jnguyen/fixes-for-fsc into 34a7bf0 on master.

@opti-jnguyen opti-jnguyen changed the title Various Fixes for FSC fix(ats): [FSSDK-9114] Various Fixes for FSC Apr 13, 2023
@opti-jnguyen opti-jnguyen marked this pull request as ready for review April 19, 2023 19:57
@opti-jnguyen opti-jnguyen requested a review from a team as a code owner April 19, 2023 19:57
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@opti-jnguyen opti-jnguyen merged commit 082c086 into master May 3, 2023
@opti-jnguyen opti-jnguyen deleted the jnguyen/fixes-for-fsc branch May 3, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants