[FSSDK-9152] Fix "client_initialized" event not firing (#820)

Author: mikechu-optimizely

packages/optimizely-sdk/lib/core/odp/odp_event_manager.ts

@@ -247,11 +247,6 @@ export abstract class OdpEventManager implements IOdpEventManager {
       return;
     }
 
-    if (!this.odpConfig.isReady()) {
-      this.logger.log(LogLevel.DEBUG, 'Unable to Process ODP Event. ODPConfig is not ready.');
-      return;
-    }
-
     if (this.queue.length >= this.queueSize) {
       this.logger.log(
         LogLevel.WARNING,

packages/optimizely-sdk/lib/index.browser.tests.js

@@ -903,6 +903,40 @@ describe('javascript-sdk (Browser)', function() {
 
         sinon.assert.notCalled(logger.error);
       });
+
+      it('should send odp client_initialized on client instantiation', async () => {
+        const odpConfig = new OdpConfig();
+        const apiManager = new BrowserOdpEventApiManager(mockRequestHandler, logger);
+        sinon.spy(apiManager, 'sendEvents');
+        const eventManager = new BrowserOdpEventManager({
+           odpConfig,
+           apiManager,
+           logger,
+        });
+        const datafile = testData.getOdpIntegratedConfigWithSegments();
+        const client = optimizelyFactory.createInstance({
+          datafile,
+          errorHandler: fakeErrorHandler,
+          eventDispatcher: fakeEventDispatcher,
+          eventBatchSize: null,
+          logger,
+          odpOptions: {
+            odpConfig,
+            eventManager,
+          },
+        });
+
+        const readyData = await client.onReady();
+        assert.equal(readyData.success, true);
+        assert.isUndefined(readyData.reason);
+
+        clock.tick(100);
+
+        const [,,events] = apiManager.sendEvents.getCall(0).args;
+        const [firstEvent] = events;
+        assert.equal(firstEvent.action, 'client_initialized');
+        assert.equal(firstEvent.type, 'fullstack');
+      });
     });
   });
 });

packages/optimizely-sdk/tests/odpEventManager.spec.ts

@@ -168,7 +168,8 @@ describe('OdpEventManager', () => {
 
     eventManager.sendEvent(EVENTS[0]);
 
-    verify(mockLogger.log(LogLevel.DEBUG, 'Unable to Process ODP Event. ODPConfig is not ready.')).once();
+    // In a Node context, the events should be discarded
+    verify(mockLogger.log(LogLevel.WARNING, 'ODPConfig not ready. Discarding events in queue.')).once();
   });
 
   it('should discard events with invalid data', () => {