Skip to content

feat: Implement trackEvent api #636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 4, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/optimizely-sdk/lib/optimizely/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1603,7 +1603,6 @@ export default class Optimizely {
* @param {OptimizelyDecideOptions[]} options An array of options for decision-making.
* @return {[key: string]: OptimizelyDecision} An object of decision results mapped by flag keys.
*/

decideForKeys(
user: OptimizelyUserContext,
keys: string[],
Expand Down
22 changes: 22 additions & 0 deletions packages/optimizely-sdk/lib/optimizely_user_context/index.tests.js
Original file line number Diff line number Diff line change
Expand Up @@ -262,5 +262,27 @@ describe('lib/optimizely_user_context', function() {
assert.deepEqual(decisionMap, fakeDecisionMap);
});
});

describe('#trackEvent', function() {
it('should call track from optimizely client', function() {
fakeOptimizely = {
track: sinon.stub()
};
var eventName = 'myEvent';
var eventTags = { 'eventTag1': 1000 }
var user = new OptimizelyUserContext({
optimizely: fakeOptimizely,
userId,
});
user.trackEvent(eventName, eventTags);
sinon.assert.calledWithExactly(
fakeOptimizely.track,
eventName,
user.getUserId(),
user.getAttributes(),
eventTags,
);
});
});
});
});
11 changes: 10 additions & 1 deletion packages/optimizely-sdk/lib/optimizely_user_context/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
* limitations under the License. *
***************************************************************************/
import Optimizely from '../../lib/optimizely';
import { UserAttributes, OptimizelyDecideOptions } from '../../lib/shared_types';
import { UserAttributes, OptimizelyDecideOptions, EventTags } from '../../lib/shared_types';
import { OptimizelyDecision } from '../optimizely_decision';

export default class OptimizelyUserContext {
Expand Down Expand Up @@ -99,4 +99,13 @@ export default class OptimizelyUserContext {

return this.optimizely.decideAll(this, options);
}

/**
* Tracks an event.
* @param {string} eventName The event name.
* @param {EventTags} eventTags An optional map of event tag names to event tag values.
*/
trackEvent(eventName: string, eventTags?: EventTags): void {
this.optimizely.track(eventName, this.userId, this.attributes, eventTags);
}
}