Skip to content

feat: Implement trackEvent api #636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 4, 2021
Merged

feat: Implement trackEvent api #636

merged 4 commits into from
Jan 4, 2021

Conversation

yavorona
Copy link
Contributor

@yavorona yavorona commented Dec 11, 2020 •
edited
Loading

Summary

  • Implemented trackEvent from user context

Test plan

  • Manual testing + unit tests

@yavorona yavorona requested a review from a team as a code owner December 11, 2020 23:29
@coveralls
Copy link

coveralls commented Dec 11, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.003%) to 96.767% when pulling de38388 on pnguen/implement-trackEvent into 28ac953 on master.

@yavorona yavorona force-pushed the pnguen/implement-trackEvent branch from 3867fa1 to 4c36666 Compare December 12, 2020 00:04
@yavorona yavorona removed their assignment Dec 12, 2020
@yavorona yavorona requested review from jaeopt and mjc1283 December 12, 2020 00:05
jaeopt
jaeopt approved these changes Dec 12, 2020
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yavorona yavorona closed this Dec 12, 2020
@yavorona yavorona reopened this Dec 12, 2020
@yavorona yavorona closed this Dec 12, 2020
@yavorona yavorona reopened this Dec 12, 2020
@yavorona yavorona removed their assignment Dec 12, 2020
@yavorona yavorona closed this Dec 12, 2020
@yavorona yavorona reopened this Dec 12, 2020
@yavorona yavorona force-pushed the pnguen/implement-trackEvent branch from 4c36666 to de38388 Compare January 4, 2021 19:15
@yavorona yavorona merged commit c792210 into master Jan 4, 2021
@yavorona yavorona deleted the pnguen/implement-trackEvent branch January 4, 2021 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjc1283 mjc1283 mjc1283 approved these changes

@jaeopt jaeopt jaeopt approved these changes

Assignees

@yavorona yavorona

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yavorona @coveralls @mjc1283 @jaeopt