Skip to content

Incorporate New Optimizely endpoint in event dispatcher and bump version #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 19, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
-------------------------------------------------------------------------------
0.1.4
-------------------------------------------------------------------------------
* Add functionality for New Optimizely endpoint.
-------------------------------------------------------------------------------

-------------------------------------------------------------------------------
0.1.3
-------------------------------------------------------------------------------
Expand Down
12 changes: 6 additions & 6 deletions dist/optimizely.min.js

Large diffs are not rendered by default.

53 changes: 36 additions & 17 deletions lib/plugins/event_dispatcher/index.js
Original file line number Diff line number Diff line change
@@ -1,35 +1,54 @@
var _ = require('lodash/core');
var bluebird = require('bluebird');

var POST_METHOD = 'POST';
var GET_METHOD = 'GET';

module.exports = {
/**
* Sample event dispatcher implementation for tracking impression and conversions
* Users of the SDK can provide their own implementation
* @param {string} url
* @param {Object} params
* @param {Object} eventObj
* @return {Promise<Object>}
*/
dispatchEvent: function(url, params) {
return new bluebird(function(resolve, reject) {
// add param for cors headers to be sent by the log endpoint
url += '?wxhr=true';
if (params) {
url += '&' + toQueryString(params);
}
dispatchEvent: function(eventObj) {
var url = eventObj.url;
var params = eventObj.params;

if (eventObj.httpVerb === POST_METHOD) {
return new bluebird(function(resolve, reject) {

var req = new XMLHttpRequest();
req.open(POST_METHOD, url, true);
req.setRequestHeader('Content-Type', 'application/json');
req.addEventListener('load', function (evt) {
var responseObj = evt.target.responseText;
resolve(responseObj);
});
req.send(JSON.stringify(params));
})
} else {
return new bluebird(function (resolve, reject) {
// add param for cors headers to be sent by the log endpoint
url += '?wxhr=true';
if (params) {
url += '&' + toQueryString(params);
}

var req = new XMLHttpRequest();
req.open('GET', url, true);
req.addEventListener('load', function(evt) {
var responseObj = JSON.parse(evt.target.responseText);
resolve(responseObj);
var req = new XMLHttpRequest();
req.open(GET_METHOD, url, true);
req.addEventListener('load', function (evt) {
var responseObj = JSON.parse(evt.target.responseText);
resolve(responseObj);
});
req.send();
});
req.send();
});
}
},
};

var toQueryString = function(obj) {
return _.map(obj, function(v, k){
return _.map(obj, function(v, k) {
return encodeURIComponent(k) + '=' + encodeURIComponent(v);
}).join('&');
};
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "optimizely-client-sdk",
"version": "0.1.3",
"version": "0.1.4",
"description": "Javascript SDK for client testing",
"main": "index.js",
"scripts": {
Expand All @@ -21,7 +21,7 @@
"dependencies": {
"bluebird": "^3.4.0",
"lodash": "^4.13.1",
"optimizely-server-sdk": "^0.1.3"
"optimizely-server-sdk": "^0.1.4"
},
"devDependencies": {
"chai": "^3.5.0",
Expand Down